chrome/test/chromedriver/session_commands.cc - Issue 2125123002: [chromedriver] Add page loading strategy to capabilities

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/session_commands.cc

Issue 2125123002: [chromedriver] Add page loading strategy to capabilities (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: clearer naming, checks for valid strategies earlier in parsing Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/test/chromedriver/chrome/web_view_impl.cc ('K') | « chrome/test/chromedriver/client/chromedriver.py ('k') | chrome/test/chromedriver/test/run_py_tests.py » ('j') | chrome/test/chromedriver/test/run_py_tests.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/chromedriver/session_commands.cc

diff --git a/chrome/test/chromedriver/session_commands.cc b/chrome/test/chromedriver/session_commands.cc

index 48ad77d7f1c7bddb310ff719df20b306b89bc8b0..75cc6e4c05b2b22cf30e71ca5dafedcca9b4ab85 100644

--- a/chrome/test/chromedriver/session_commands.cc

+++ b/chrome/test/chromedriver/session_commands.cc

@@ -97,6 +97,7 @@ std::unique_ptr<base::DictionaryValue> CreateCapabilities(Chrome* chrome) {

caps->SetString("version", chrome->GetBrowserInfo()->browser_version);

caps->SetString("chrome.chromedriverVersion", kChromeDriverVersion);

caps->SetString("platform", chrome->GetOperatingSystemName());

+ caps->SetString("pageLoadStrategy", chrome->page_load_strategy());

caps->SetBoolean("javascriptEnabled", true);

caps->SetBoolean("takesScreenshot", true);

caps->SetBoolean("takesHeapSnapshot", true);

@@ -199,6 +200,8 @@ Status InitSessionHelper(const InitSessionParams& bound_params,

if (status.IsError())

return status;

+ session->chrome->set_page_load_strategy(capabilities.page_load_strategy);

std::list<std::string> web_view_ids;

status = session->chrome->GetWebViewIds(&web_view_ids);

if (status.IsError() || web_view_ids.empty()) {