chrome/test/chromedriver/chrome/devtools_http_client.h - Issue 2125123002: [chromedriver] Add page loading strategy to capabilities

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/chrome/devtools_http_client.h

Issue 2125123002: [chromedriver] Add page loading strategy to capabilities (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: clearer naming, checks for valid strategies earlier in parsing Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/chromedriver/chrome/chrome_impl.cc ('k') | chrome/test/chromedriver/chrome/devtools_http_client.cc » ('j') | chrome/test/chromedriver/chrome/non_blocking_navigation_tracker.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/chromedriver/chrome/devtools_http_client.h

diff --git a/chrome/test/chromedriver/chrome/devtools_http_client.h b/chrome/test/chromedriver/chrome/devtools_http_client.h

index b009d9efcf11a5249dd6bc4d40996aae0c18c393..93e55476bbd634ef976e493065c734b25d33a0a5 100644

--- a/chrome/test/chromedriver/chrome/devtools_http_client.h

+++ b/chrome/test/chromedriver/chrome/devtools_http_client.h

@@ -75,7 +75,8 @@ class DevToolsHttpClient {

scoped_refptr<URLRequestContextGetter> context_getter,

const SyncWebSocketFactory& socket_factory,

std::unique_ptr<DeviceMetrics> device_metrics,

- std::unique_ptr<std::set<WebViewInfo::Type>> window_types);

+ std::unique_ptr<std::set<WebViewInfo::Type>> window_types,

+ std::string page_load_strategy);

~DevToolsHttpClient();

Status Init(const base::TimeDelta& timeout);

@@ -105,6 +106,7 @@ class DevToolsHttpClient {

BrowserInfo browser_info_;

std::unique_ptr<DeviceMetrics> device_metrics_;

std::unique_ptr<std::set<WebViewInfo::Type>> window_types_;

+ std::string page_load_strategy_;

DISALLOW_COPY_AND_ASSIGN(DevToolsHttpClient);

};