chrome/test/chromedriver/chrome/chrome_impl.h - Issue 2125123002: [chromedriver] Add page loading strategy to capabilities

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/chrome/chrome_impl.h

Issue 2125123002: [chromedriver] Add page loading strategy to capabilities (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: clearer naming, checks for valid strategies earlier in parsing Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/chromedriver/chrome/chrome_desktop_impl.cc ('k') | chrome/test/chromedriver/chrome/chrome_impl.cc » ('j') | chrome/test/chromedriver/chrome/non_blocking_navigation_tracker.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/chromedriver/chrome/chrome_impl.h

diff --git a/chrome/test/chromedriver/chrome/chrome_impl.h b/chrome/test/chromedriver/chrome/chrome_impl.h

index fd4a20dae363ef15769006236ae1c361e1196e91..961eb89268fdd4b841e32dc41dc3927e25871a6d 100644

--- a/chrome/test/chromedriver/chrome/chrome_impl.h

+++ b/chrome/test/chromedriver/chrome/chrome_impl.h

@@ -40,6 +40,8 @@ class ChromeImpl : public Chrome {

Status ActivateWebView(const std::string& id) override;

bool IsMobileEmulationEnabled() const override;

bool HasTouchScreen() const override;

+ std::string page_load_strategy() const override;

+ void set_page_load_strategy(std::string strategy) override;

Status Quit() override;

protected:

@@ -55,6 +57,7 @@ class ChromeImpl : public Chrome {

std::unique_ptr<DevToolsClient> devtools_websocket_client_;

private:

+ std::string page_load_strategy_;

typedef std::list<linked_ptr<WebViewImpl> > WebViewList;

// Web views in this list are in the same order as they are opened.