chrome/test/chromedriver/chrome/chrome.h - Issue 2125123002: [chromedriver] Add page loading strategy to capabilities

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/chrome/chrome.h

Issue 2125123002: [chromedriver] Add page loading strategy to capabilities (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: clearer naming, checks for valid strategies earlier in parsing Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/chromedriver/capabilities.cc ('k') | chrome/test/chromedriver/chrome/chrome_desktop_impl.cc » ('j') | chrome/test/chromedriver/chrome/non_blocking_navigation_tracker.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/chromedriver/chrome/chrome.h

diff --git a/chrome/test/chromedriver/chrome/chrome.h b/chrome/test/chromedriver/chrome/chrome.h

index a0957dfbaecc18b629e2adfe1d14a3747310fca4..2dd3e831111c5e8b80fbec4a4a6375dd971614d8 100644

--- a/chrome/test/chromedriver/chrome/chrome.h

+++ b/chrome/test/chromedriver/chrome/chrome.h

@@ -47,6 +47,10 @@ class Chrome {

// actions can be performed on it.

virtual bool HasTouchScreen() const = 0;

+ virtual std::string page_load_strategy() const = 0;

+ virtual void set_page_load_strategy(std::string strategy) = 0;

// Quits Chrome.

virtual Status Quit() = 0;

};