Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8828)

Unified Diff: chrome/test/chromedriver/chrome/web_view_impl.h

Issue 2125123002: [chromedriver] Add page loading strategy to capabilities (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed merge conflicts Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/chrome/web_view_impl.h
diff --git a/chrome/test/chromedriver/chrome/web_view_impl.h b/chrome/test/chromedriver/chrome/web_view_impl.h
index 4bb821d10d7ca7c6971a81325e34e64e8a117f84..c7f11edfca12333b874c855c57bcae5b866d2be5 100644
--- a/chrome/test/chromedriver/chrome/web_view_impl.h
+++ b/chrome/test/chromedriver/chrome/web_view_impl.h
@@ -32,6 +32,8 @@ class HeapSnapshotTaker;
struct KeyEvent;
struct MouseEvent;
class NavigationTracker;
+class NavigationTrackerNone;
+class PageLoadingStrategy;
class Status;
class WebViewImpl : public WebView {
@@ -42,7 +44,8 @@ class WebViewImpl : public WebView {
WebViewImpl(const std::string& id,
const BrowserInfo* browser_info,
std::unique_ptr<DevToolsClient> client,
- const DeviceMetrics* device_metrics);
+ const DeviceMetrics* device_metrics,
+ std::string strategy);
~WebViewImpl() override;
// Overridden from WebView:
@@ -129,7 +132,7 @@ class WebViewImpl : public WebView {
std::unique_ptr<DomTracker> dom_tracker_;
std::unique_ptr<FrameTracker> frame_tracker_;
std::unique_ptr<JavaScriptDialogManager> dialog_manager_;
- std::unique_ptr<NavigationTracker> navigation_tracker_;
+ std::unique_ptr<PageLoadingStrategy> navigation_tracker_;
std::unique_ptr<MobileEmulationOverrideManager>
mobile_emulation_override_manager_;
std::unique_ptr<GeolocationOverrideManager> geolocation_override_manager_;

Powered by Google App Engine
This is Rietveld 408576698