Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10181)

Unified Diff: chrome/test/chromedriver/client/chromedriver.py

Issue 2125123002: [chromedriver] Add page loading strategy to capabilities (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixed unittests, renamed py tests Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/chromedriver/chrome_launcher.cc ('k') | chrome/test/chromedriver/session_commands.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/client/chromedriver.py
diff --git a/chrome/test/chromedriver/client/chromedriver.py b/chrome/test/chromedriver/client/chromedriver.py
index baa09ff320ebdab984195745462a974f42c85ff1..44b921625142d738eb79c116301210995e94cc87 100644
--- a/chrome/test/chromedriver/client/chromedriver.py
+++ b/chrome/test/chromedriver/client/chromedriver.py
@@ -72,7 +72,8 @@ class ChromeDriver(object):
chrome_extensions=None, chrome_log_path=None,
debugger_address=None, logging_prefs=None,
mobile_emulation=None, experimental_options=None,
- download_dir=None, network_connection=None):
+ download_dir=None, page_load_strategy=None,
+ network_connection=None):
self._executor = command_executor.CommandExecutor(server_url)
options = {}
@@ -144,6 +145,10 @@ class ChromeDriver(object):
}
}
+ if page_load_strategy:
+ assert type(page_load_strategy) is str
+ params['desiredCapabilities']['pageLoadStrategy'] = page_load_strategy
+
if network_connection:
params['desiredCapabilities']['networkConnectionEnabled'] = (
network_connection)
« no previous file with comments | « chrome/test/chromedriver/chrome_launcher.cc ('k') | chrome/test/chromedriver/session_commands.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698