Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(585)

Side by Side Diff: chrome/test/chromedriver/chrome/page_load_strategy.h

Issue 2125123002: [chromedriver] Add page loading strategy to capabilities (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: clearer naming, checks for valid strategies earlier in parsing Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright (c) 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef CHROME_TEST_CHROMEDRIVER_CHROME_PAGE_LOAD_STRATEGY_H_
6 #define CHROME_TEST_CHROMEDRIVER_CHROME_PAGE_LOAD_STRATEGY_H_
7
8 #include "chrome/test/chromedriver/chrome/status.h"
9
10 struct BrowserInfo;
11 class DevToolsClient;
12 class JavaScriptDialogManager;
13 class Status;
14 class Timeout;
15
16 class PageLoadStrategy {
17 public:
samuong 2016/07/29 23:33:45 nit: one space before "public:"
samuong 2016/07/29 23:33:46 nit: one space before "public:"
evajiang 2016/08/01 16:35:46 Done.
18 enum LoadingState {
19 kUnknown,
20 kLoading,
21 kNotLoading,
22 };
23
24 virtual ~PageLoadStrategy() {}
25
26 static PageLoadStrategy* Create(
27 std::string strategy,
28 DevToolsClient* client,
29 const BrowserInfo* browser_info,
30 const JavaScriptDialogManager* dialog_manager);
31
32 virtual Status IsPendingNavigation(const std::string& frame_id,
33 const Timeout* timeout,
34 bool* is_pending) = 0;
35
36 virtual void set_timed_out(bool timed_out) = 0;
37
38 // Types of page load strategies.
39 static const char kNormal[];
40 static const char kNone[];
41 static const char kEager[];
42 };
43
44 #endif // CHROME_TEST_CHROMEDRIVER_CHROME_PAGE_LOAD_STRATEGY_H_
samuong 2016/07/29 23:33:45 nit: two spaces before "//"
samuong 2016/07/29 23:33:45 nit: two spaces before "//"
evajiang 2016/08/01 16:35:46 Done.
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698