Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 2125063004: Fix typo in code_generator_v8.py error message (Closed)

Created:
4 years, 5 months ago by johnme
Modified:
4 years, 5 months ago
Reviewers:
haraken, bashi
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix typo in code_generator_v8.py error message BUG=none Committed: https://crrev.com/082876988297720baf61a333e81d8cf980f33c28 Cr-Commit-Position: refs/heads/master@{#404367}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/bindings/scripts/code_generator_v8.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
johnme
4 years, 5 months ago (2016-07-07 18:08:44 UTC) #2
bashi
lgtm thanks!
4 years, 5 months ago (2016-07-07 22:54:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2125063004/1
4 years, 5 months ago (2016-07-07 22:55:16 UTC) #5
haraken
LGTM
4 years, 5 months ago (2016-07-08 00:50:58 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_gyp_rel on master.tryserver.chromium.mac (JOB_TIMED_OUT, no build URL)
4 years, 5 months ago (2016-07-08 00:57:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2125063004/1
4 years, 5 months ago (2016-07-08 09:40:23 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-08 14:19:33 UTC) #11
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-08 14:19:38 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-08 14:21:50 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/082876988297720baf61a333e81d8cf980f33c28
Cr-Commit-Position: refs/heads/master@{#404367}

Powered by Google App Engine
This is Rietveld 408576698