Issue 2125063003: Add async variant of ProofSource::GetProof

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2125063003: Add async variant of ProofSource::GetProof (Closed)

Created:
4 years, 5 months ago by rjshade

Modified:
4 years, 5 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@126463885

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Add async variant of ProofSource::GetProof Merge internal change: 126468067 R=rch@chromium.org BUG=

Patch Set 1 #

Total comments: 1

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+143 lines, -4 lines)			Patch
M	net/quic/crypto/proof_source.h	View	5 chunks	+45 lines, -4 lines	0 comments	Download
M	net/quic/crypto/proof_source_chromium.h	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	net/quic/crypto/proof_source_chromium.cc	View	1 chunk	+21 lines, -0 lines	1 comment	Download
M	net/quic/crypto/proof_test.cc	View	2 chunks	+69 lines, -0 lines	0 comments	Download

Depends on Patchset:

Issue 2126053003 Patch 1

Dependent Patchsets:

Issue 2131553002 Patch 1

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ryan Hamilton

lgtm, modulo one nit https://codereview.chromium.org/2125063003/diff/1/net/quic/crypto/proof_source_chromium.cc File net/quic/crypto/proof_source_chromium.cc (right): https://codereview.chromium.org/2125063003/diff/1/net/quic/crypto/proof_source_chromium.cc#newcode165 net/quic/crypto/proof_source_chromium.cc:165: // that it gets deleted ...

4 years, 5 months ago (2016-07-07 16:34:00 UTC) #2

rjshade

4 years, 5 months ago (2016-07-07 16:52:05 UTC) #3

On 2016/07/07 16:34:00, Ryan Hamilton wrote:
> lgtm, modulo one nit
> 
>
https://codereview.chromium.org/2125063003/diff/1/net/quic/crypto/proof_sourc...
> File net/quic/crypto/proof_source_chromium.cc (right):
> 
>
https://codereview.chromium.org/2125063003/diff/1/net/quic/crypto/proof_sourc...
> net/quic/crypto/proof_source_chromium.cc:165: // that it gets deleted after it
> is invoked.
> Since proof_source_chromium is not shared, I think we'll ever end up doing an
> RPC. So how 'bout just nuking this comment?

Done in Final: https://codereview.chromium.org/2132623002/

Expand Messages | Collapse Messages