Make Desktop Capture New Feature Default On

Make Desktop Capture New Feature Default On

We've finished the development of
1. Capturing a single chromium tab for desktop share
2. A new picker UI, which is more user friendly

During the developement, we hide the new feature behind a flag.
This CL makes the new feature default on.

BUG=557222, 624898
Committed: https://crrev.com/06a098504c69edf8a47b792da97e36ee807e4eb3
Cr-Commit-Position: refs/heads/master@{#404424}

[qiangchen, 2016-07-06 17:37:42]

Patchset #1 (id:1) has been deleted

[qiangchen, 2016-07-06 17:42:44]

Description was changed from

==========
Make Desktop Capture New Feature Default On

BUG=624898
==========

to

==========
Make Desktop Capture New Feature Default On

We've finished the development of 
1. Capturing a single chromium tab for desktop share
2. A new picker UI, which is more user friendly

During the developement, we hide the new feature behind a flag.
This CL makes the new feature default on.

BUG=624898
==========

[qiangchen, 2016-07-06 18:04:25]

Patchset #1 (id:20001) has been deleted

[qiangchen, 2016-07-06 20:28:43]

qiangchen@chromium.org changed reviewers:
+ isherman@chromium.org, msw@chromium.org, rockot@chromium.org

[qiangchen, 2016-07-06 20:31:31]

This CL makes desktop capture new feature default on.

PTAL.

[qiangchen, 2016-07-06 22:04:17]

Description was changed from

==========
Make Desktop Capture New Feature Default On

We've finished the development of 
1. Capturing a single chromium tab for desktop share
2. A new picker UI, which is more user friendly

During the developement, we hide the new feature behind a flag.
This CL makes the new feature default on.

BUG=624898
==========

to

==========
Make Desktop Capture New Feature Default On

We've finished the development of 
1. Capturing a single chromium tab for desktop share
2. A new picker UI, which is more user friendly

During the developement, we hide the new feature behind a flag.
This CL makes the new feature default on.

BUG=557222, 624898
==========

[Ken Rockot(use gerrit already), 2016-07-06 22:07:08]

Is there a good reason to invert the flag rather than just remove it?

[qiangchen, 2016-07-06 22:36:40]

On 2016/07/06 22:07:08, Ken Rockot wrote:
> Is there a good reason to invert the flag rather than just remove it?

In case something broken, this way can let the tester disable the flag and
continue workflow.
On the other hand, we have some deprecated code to remove, so I think it is
better to make a light weighted CL to invert the flag first, and completely
remove the flag and deprecated code after a couple of weeks.

[Ilya Sherman, 2016-07-06 22:46:03]

histograms.xml lgtm

[Ken Rockot(use gerrit already), 2016-07-07 04:42:35]

lgtm

[msw, 2016-07-07 18:34:16]

lgtm with a nit

https://codereview.chromium.org/2125063002/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/api/desktop_capture/desktop_capture_base.cc
(right):

https://codereview.chromium.org/2125063002/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/api/desktop_capture/desktop_capture_base.cc:20:
#include "chrome/common/channel_info.h"
nit: remove

[qiangchen, 2016-07-08 17:13:09]

The CQ bit was checked by qiangchen@chromium.org

[qiangchen, 2016-07-08 17:13:10]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org,
isherman@chromium.org, msw@chromium.org
Link to the patchset: https://codereview.chromium.org/2125063002/#ps60001
(title: "Remove include")

[qiangchen, 2016-07-08 17:13:22]

https://codereview.chromium.org/2125063002/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/api/desktop_capture/desktop_capture_base.cc
(right):

https://codereview.chromium.org/2125063002/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/api/desktop_capture/desktop_capture_base.cc:20:
#include "chrome/common/channel_info.h"
On 2016/07/07 18:34:16, msw wrote:
> nit: remove

Done.

[commit-bot: I haz the power, 2016-07-08 17:14:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-08 17:19:26]

Description was changed from

==========
Make Desktop Capture New Feature Default On

We've finished the development of 
1. Capturing a single chromium tab for desktop share
2. A new picker UI, which is more user friendly

During the developement, we hide the new feature behind a flag.
This CL makes the new feature default on.

BUG=557222, 624898
==========

to

==========
Make Desktop Capture New Feature Default On

We've finished the development of 
1. Capturing a single chromium tab for desktop share
2. A new picker UI, which is more user friendly

During the developement, we hide the new feature behind a flag.
This CL makes the new feature default on.

BUG=557222, 624898
==========

[commit-bot: I haz the power, 2016-07-08 17:19:27]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2016-07-08 17:19:38]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-08 17:22:17]

Description was changed from

==========
Make Desktop Capture New Feature Default On

We've finished the development of 
1. Capturing a single chromium tab for desktop share
2. A new picker UI, which is more user friendly

During the developement, we hide the new feature behind a flag.
This CL makes the new feature default on.

BUG=557222, 624898
==========

to

==========
Make Desktop Capture New Feature Default On

We've finished the development of
1. Capturing a single chromium tab for desktop share
2. A new picker UI, which is more user friendly

During the developement, we hide the new feature behind a flag.
This CL makes the new feature default on.

BUG=557222, 624898

Committed: https://crrev.com/06a098504c69edf8a47b792da97e36ee807e4eb3
Cr-Commit-Position: refs/heads/master@{#404424}
==========

[commit-bot: I haz the power, 2016-07-08 17:22:18]

Patchset 2 (id:??) landed as
https://crrev.com/06a098504c69edf8a47b792da97e36ee807e4eb3
Cr-Commit-Position: refs/heads/master@{#404424}