Fix crash with OSR after isolate reload.

Fix crash with OSR after isolate reload.

If a reload happens before doing OSR in the same invocation,
we have to abort OSR since the unoptimized code has been discarded.

BUG=#26806
R=rmacnak@google.com

Committed: https://github.com/dart-lang/sdk/commit/eb12e9369a4e0d55d675adb8f46255a0db9c7cd7

[Florian Schneider, 2016-07-06 16:48:48]

fschneider@google.com changed reviewers:
+ rmacnak@google.com

[rmacnak, 2016-07-06 17:31:57]

https://codereview.chromium.org/2125053002/diff/1/runtime/vm/code_generator.cc
File runtime/vm/code_generator.cc (right):

https://codereview.chromium.org/2125053002/diff/1/runtime/vm/code_generator.c...
runtime/vm/code_generator.cc:1363: // The unoptimized code can have been reset
to the lazy-compile stub
As discussed offline, this should be

if (frame.code != frame.code.function.unoptimizedcode) {
  bailout, the frame's code is old, probably from before a reload.
  compiling osr may result in code with different deopt ids.
}

[Florian Schneider, 2016-07-07 19:06:40]

ptal

[rmacnak, 2016-07-07 21:24:44]

lgtm

[Florian Schneider, 2016-07-07 22:32:05]

Description was changed from

==========
Fix crash with OSR after isolate reload.

If a reload happens before doing OSR in the same invocation,
we have to abort OSR since the unoptimized code has been discarded.

BUG=#26806
==========

to

==========
Fix crash with OSR after isolate reload.

If a reload happens before doing OSR in the same invocation,
we have to abort OSR since the unoptimized code has been discarded.

BUG=#26806
R=rmacnak@google.com

Committed:
https://github.com/dart-lang/sdk/commit/eb12e9369a4e0d55d675adb8f46255a0db9c7cd7
==========

[Florian Schneider, 2016-07-07 22:32:06]

Committed patchset #2 (id:20001) manually as
eb12e9369a4e0d55d675adb8f46255a0db9c7cd7 (presubmit successful).