Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2125023004: Remove v8- prefix of file name in libsampler. (Closed)

Created:
4 years, 5 months ago by lpy
Modified:
4 years, 5 months ago
Reviewers:
alph, Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove v8- prefix of file name in libsampler. BUG= Committed: https://crrev.com/4e53b1a1a7644a659380def93327f212e26a0ab3 Cr-Commit-Position: refs/heads/master@{#37599}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -785 lines) Patch
M BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M src/isolate.cc View 1 chunk +1 line, -1 line 0 comments Download
A + src/libsampler/sampler.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/libsampler/sampler.cc View 1 chunk +1 line, -1 line 0 comments Download
D src/libsampler/v8-sampler.h View 1 chunk +0 lines, -103 lines 0 comments Download
D src/libsampler/v8-sampler.cc View 1 chunk +0 lines, -673 lines 0 comments Download
M src/log.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/profiler/cpu-profiler.h View 1 chunk +1 line, -1 line 0 comments Download
M src/v8.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/v8.gyp View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/libsampler/test-sampler.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (7 generated)
lpy
ptal.
4 years, 5 months ago (2016-07-07 20:55:07 UTC) #2
alph
lgtm
4 years, 5 months ago (2016-07-07 21:02:57 UTC) #3
Yang
On 2016/07/07 21:02:57, alph wrote: > lgtm lgtm.
4 years, 5 months ago (2016-07-08 06:06:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2125023004/1
4 years, 5 months ago (2016-07-08 06:20:06 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2125023004/1
4 years, 5 months ago (2016-07-08 06:20:56 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-07-08 06:41:07 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2125023004/1
4 years, 5 months ago (2016-07-08 06:42:26 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-08 06:44:56 UTC) #14
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-08 06:44:59 UTC) #15
commit-bot: I haz the power
4 years, 5 months ago (2016-07-08 06:48:07 UTC) #17
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/4e53b1a1a7644a659380def93327f212e26a0ab3
Cr-Commit-Position: refs/heads/master@{#37599}

Powered by Google App Engine
This is Rietveld 408576698