Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Unified Diff: gpu/command_buffer/service/gles2_cmd_decoder.cc

Issue 2125023002: Reland "webgl: use immutable texture for the default FBO." (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: m_webGLVersion > WebGL1 (for future versions) Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | gpu/command_buffer/tests/gl_copy_texture_CHROMIUM_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/command_buffer/service/gles2_cmd_decoder.cc
diff --git a/gpu/command_buffer/service/gles2_cmd_decoder.cc b/gpu/command_buffer/service/gles2_cmd_decoder.cc
index 9b2a4e43b5f1eaae87ce86ee7f183dea70346478..3491223854744ffe23d1136248aabeb49e2ca252 100644
--- a/gpu/command_buffer/service/gles2_cmd_decoder.cc
+++ b/gpu/command_buffer/service/gles2_cmd_decoder.cc
@@ -14396,15 +14396,19 @@ bool GLES2DecoderImpl::ValidateCopyTextureCHROMIUMInternalFormats(
// The destination format should be GL_RGB, or GL_RGBA. GL_ALPHA,
// GL_LUMINANCE, and GL_LUMINANCE_ALPHA are not supported because they are not
// renderable on some platforms.
- bool valid_dest_format = dest_internal_format == GL_RGB ||
- dest_internal_format == GL_RGBA ||
- dest_internal_format == GL_BGRA_EXT;
+ bool valid_dest_format =
+ dest_internal_format == GL_RGB || dest_internal_format == GL_RGBA ||
+ dest_internal_format == GL_RGB8 || dest_internal_format == GL_RGBA8 ||
+ dest_internal_format == GL_BGRA_EXT ||
+ dest_internal_format == GL_BGRA8_EXT;
bool valid_source_format =
source_internal_format == GL_RED || source_internal_format == GL_ALPHA ||
source_internal_format == GL_RGB || source_internal_format == GL_RGBA ||
+ source_internal_format == GL_RGB8 || source_internal_format == GL_RGBA8 ||
source_internal_format == GL_LUMINANCE ||
source_internal_format == GL_LUMINANCE_ALPHA ||
source_internal_format == GL_BGRA_EXT ||
+ source_internal_format == GL_BGRA8_EXT ||
source_internal_format == GL_RGB_YCBCR_420V_CHROMIUM ||
source_internal_format == GL_RGB_YCBCR_422_CHROMIUM;
if (!valid_source_format || !valid_dest_format) {
« no previous file with comments | « no previous file | gpu/command_buffer/tests/gl_copy_texture_CHROMIUM_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698