Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 2125003002: Move CrossThreadCopier from platform/ to wtf/

Created:
4 years, 5 months ago by hiroshige
Modified:
4 years, 5 months ago
Reviewers:
sof, Yuta Kitamura, tzik
CC:
chromium-reviews, blink-reviews-platform-graphics_chromium.org, dshwang, eae+blinkwatch, apavlov+blink_chromium.org, blink-reviews-wtf_chromium.org, rwlbuis, krit, drott+blinkwatch_chromium.org, blink-reviews-css, Justin Novosad, blink-reviews-dom_chromium.org, dglazkov+blink, Rik, blink-reviews-bindings_chromium.org, gavinp+loader_chromium.org, blink-reviews, ajuma+watch_chromium.org, Mads Ager (chromium), sof, jbroman, loading-reviews_chromium.org, pdr+graphicswatchlist_chromium.org, darktears, loading-reviews+fetch_chromium.org, Nate Chapin, Stephen Chennney, tyoshino+watch_chromium.org, f(malita), oilpan-reviews, danakj+watch_chromium.org, kouhei+heap_chromium.org, Mikhail
Base URL:
https://chromium.googlesource.com/chromium/src.git@TRV_RemoveTupleInBind
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move CrossThreadCopier from platform/ to wtf/ This CL - Moves CrossThreadCopier to wtf/, - Moves each specialization of CrossThreadCopier<T> to the T's header, and make T's header to include wtf/CrossThreadCopier.h. BUG=624419

Patch Set 1 #

Patch Set 2 : Rebase #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+262 lines, -396 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/SourceLocation.h View 2 chunks +8 lines, -4 lines 1 comment Download
M third_party/WebKit/Source/core/css/MediaValuesCached.h View 2 chunks +9 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DocumentEncodingData.h View 3 chunks +9 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ResourceLoaderOptions.h View 2 chunks +10 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ResourceLoaderOptionsTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/ThreadableLoader.h View 2 chunks +13 lines, -5 lines 0 comments Download
D third_party/WebKit/Source/platform/CrossThreadCopier.h View 1 chunk +0 lines, -194 lines 0 comments Download
D third_party/WebKit/Source/platform/CrossThreadCopier.cpp View 1 chunk +0 lines, -111 lines 0 comments Download
M third_party/WebKit/Source/platform/CrossThreadFunctional.h View 2 chunks +2 lines, -2 lines 1 comment Download
M third_party/WebKit/Source/platform/blink_platform.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/geometry/IntRect.h View 2 chunks +10 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/geometry/IntSize.h View 2 chunks +10 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/Persistent.h View 3 chunks +27 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/network/ResourceError.h View 2 chunks +15 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/network/ResourceRequest.h View 2 chunks +15 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/network/ResourceResponse.h View 1 chunk +14 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/network/ResourceTimingInfo.h View 2 chunks +9 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/network/ResourceTimingInfo.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/weborigin/KURL.h View 2 chunks +11 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/wtf/CrossThreadCopier.h View 2 chunks +37 lines, -24 lines 0 comments Download
A + third_party/WebKit/Source/wtf/CrossThreadCopierTest.cpp View 1 chunk +7 lines, -32 lines 1 comment Download
M third_party/WebKit/Source/wtf/Functional.h View 3 chunks +13 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/wtf/PassRefPtr.h View 2 chunks +10 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/wtf/RefPtr.h View 2 chunks +11 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/wtf/WeakPtr.h View 2 chunks +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/WTFString.h View 2 chunks +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/WTFString.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/wtf/wtf.gypi View 2 chunks +2 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 16 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2125003002/1
4 years, 5 months ago (2016-07-06 10:21:39 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2125003002/20001
4 years, 5 months ago (2016-07-06 11:35:58 UTC) #5
hiroshige
PTAL.
4 years, 5 months ago (2016-07-06 11:44:41 UTC) #8
haraken
This looks good, but I'd like to have an md file that explains how to ...
4 years, 5 months ago (2016-07-06 12:38:29 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-07-06 13:41:31 UTC) #11
sof
https://codereview.chromium.org/2125003002/diff/20001/third_party/WebKit/Source/platform/CrossThreadFunctional.h File third_party/WebKit/Source/platform/CrossThreadFunctional.h (right): https://codereview.chromium.org/2125003002/diff/20001/third_party/WebKit/Source/platform/CrossThreadFunctional.h#newcode9 third_party/WebKit/Source/platform/CrossThreadFunctional.h:9: #include "wtf/CrossThreadCopier.h" Do you plan to move CrossThreadFunctional.h in ...
4 years, 5 months ago (2016-07-06 14:13:34 UTC) #13
tzik
Looks good. Just as an idea: Is it possible / does it look cleaner if ...
4 years, 5 months ago (2016-07-06 15:00:59 UTC) #14
Yuta Kitamura
4 years, 5 months ago (2016-07-07 07:45:59 UTC) #16
LGTM.

Moving the concept of "cross-thread copiable" to wtf/ makes
sense, since the contents of CrossThreadCopier.h and
CrossThreadFunctional.h are self-contained and do not rely
on other stuff in platform/.

[I assume the answer to sof's question is "yes".]

https://codereview.chromium.org/2125003002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/bindings/core/v8/SourceLocation.h (right):

https://codereview.chromium.org/2125003002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/core/v8/SourceLocation.h:84: } // namespace
blink
nit: This comment is false now

https://codereview.chromium.org/2125003002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/wtf/CrossThreadCopierTest.cpp (right):

https://codereview.chromium.org/2125003002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/wtf/CrossThreadCopierTest.cpp:86: } // namespace blink
Ditto

Powered by Google App Engine
This is Rietveld 408576698