Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 2124983004: [Turbofan] Change AlignSavedCalleeRegisterSlots to AlignFrame. (Closed)

Created:
4 years, 5 months ago by bbudge
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Turbofan] Change AlignSavedCalleeRegisterSlots to AlignFrame. Clean up call sites. LOG=N BUG=v8:4124 Committed: https://crrev.com/d8d75782fb90da21b92ca3dda59cfa3088ad3912 Cr-Commit-Position: refs/heads/master@{#37650}

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -32 lines) Patch
M src/compiler/arm/code-generator-arm.cc View 1 chunk +1 line, -4 lines 0 comments Download
M src/compiler/frame.h View 1 chunk +0 lines, -9 lines 0 comments Download
M src/compiler/mips/code-generator-mips.cc View 1 1 chunk +1 line, -4 lines 0 comments Download
M src/compiler/ppc/code-generator-ppc.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/s390/code-generator-s390.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 1 chunk +6 lines, -13 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
bbudge
4 years, 5 months ago (2016-07-06 21:07:35 UTC) #2
Mircea Trofin
On 2016/07/06 21:07:35, bbudge wrote: lgtm, but +danno, he may have an idea why the ...
4 years, 5 months ago (2016-07-06 21:34:58 UTC) #3
bbudge
The methods are so similar, it seems likely that any difference is actually a bug. ...
4 years, 5 months ago (2016-07-08 01:17:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2124983004/20001
4 years, 5 months ago (2016-07-11 15:00:58 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-11 15:39:37 UTC) #11
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/d8d75782fb90da21b92ca3dda59cfa3088ad3912 Cr-Commit-Position: refs/heads/master@{#37650}
4 years, 5 months ago (2016-07-11 15:41:59 UTC) #13
bbudge
4 years, 5 months ago (2016-07-13 22:37:09 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2151563003/ by bbudge@chromium.org.

The reason for reverting is: Speculative revert to fix perf regression:
https://bugs.chromium.org/p/chromium/issues/detail?id=627803.

Powered by Google App Engine
This is Rietveld 408576698