Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Issue 2124983003: cc: Remove uses of FilterOperations::GetOutsets in unit tests. (Closed)

Created:
4 years, 5 months ago by jbroman
Modified:
4 years, 5 months ago
Reviewers:
enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Remove uses of FilterOperations::GetOutsets in unit tests. The mapping from sigma to total spread was previously complicated, but it is now a straightforward multiplication by 3. This can just be embedded in the expected values in the tests. Some expressions have been fully evaluated; more complicated ones have only been simplified, but have a single variable for the blur spread left intact. BUG=600821 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/56c1f9cdc298320967bc3924d963f37ff202457e Cr-Commit-Position: refs/heads/master@{#403938}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -78 lines) Patch
M cc/trees/damage_tracker_unittest.cc View 11 chunks +33 lines, -53 lines 0 comments Download
M cc/trees/occlusion_tracker_unittest.cc View 6 chunks +11 lines, -25 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
jbroman
With this and other in-flight CLs, it should be possible to remove cc::FilterOperations::GetOutsets.
4 years, 5 months ago (2016-07-06 18:14:26 UTC) #3
enne (OOO)
lgtm
4 years, 5 months ago (2016-07-06 18:57:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2124983003/1
4 years, 5 months ago (2016-07-06 18:59:49 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-06 19:08:43 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-06 19:08:55 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-06 19:10:59 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/56c1f9cdc298320967bc3924d963f37ff202457e
Cr-Commit-Position: refs/heads/master@{#403938}

Powered by Google App Engine
This is Rietveld 408576698