Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: src/IceInst.def

Issue 2124973005: Selectively invert ICMP operands for better address optimization (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Add TODO Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/IceCfg.h ('K') | « src/IceInst.cpp ('k') | src/IceTargetLowering.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/IceInst.def
diff --git a/src/IceInst.def b/src/IceInst.def
index 6bd2efbf1c8463f69bb9dcd9ea969f82209c72f9..0f6fce264784a763b84f9b48e5e25f8e57ccb1a9 100644
--- a/src/IceInst.def
+++ b/src/IceInst.def
@@ -31,74 +31,74 @@
// representable in the destination format. This standard does not
// specify which of the input NaNs will provide the payload."
-#define ICEINSTARITHMETIC_TABLE \
- /* enum value, printable string, commutative */ \
- X(Add, "add", 1) \
- X(Fadd, "fadd", 1) \
- X(Sub, "sub", 0) \
- X(Fsub, "fsub", 0) \
- X(Mul, "mul", 1) \
- X(Fmul, "fmul", 1) \
- X(Udiv, "udiv", 0) \
- X(Sdiv, "sdiv", 0) \
- X(Fdiv, "fdiv", 0) \
- X(Urem, "urem", 0) \
- X(Srem, "srem", 0) \
- X(Frem, "frem", 0) \
- X(Shl, "shl", 0) \
- X(Lshr, "lshr", 0) \
- X(Ashr, "ashr", 0) \
- X(And, "and", 1) \
- X(Or, "or", 1) \
+#define ICEINSTARITHMETIC_TABLE \
Jim Stichnoth 2016/07/20 22:25:56 The trailing \ should be in column 80 for consiste
manasijm 2016/07/20 22:54:16 Done.
+ /* enum value, printable string, commutative */ \
+ X(Add, "add", 1) \
+ X(Fadd, "fadd", 1) \
+ X(Sub, "sub", 0) \
+ X(Fsub, "fsub", 0) \
+ X(Mul, "mul", 1) \
+ X(Fmul, "fmul", 1) \
+ X(Udiv, "udiv", 0) \
+ X(Sdiv, "sdiv", 0) \
+ X(Fdiv, "fdiv", 0) \
+ X(Urem, "urem", 0) \
+ X(Srem, "srem", 0) \
+ X(Frem, "frem", 0) \
+ X(Shl, "shl", 0) \
+ X(Lshr, "lshr", 0) \
+ X(Ashr, "ashr", 0) \
+ X(And, "and", 1) \
+ X(Or, "or", 1) \
X(Xor, "xor", 1)
//#define X(tag, str, commutative)
-#define ICEINSTCAST_TABLE \
- /* enum value, printable string */ \
- X(Trunc, "trunc") \
- X(Zext, "zext") \
- X(Sext, "sext") \
- X(Fptrunc, "fptrunc") \
- X(Fpext, "fpext") \
- X(Fptoui, "fptoui") \
- X(Fptosi, "fptosi") \
- X(Uitofp, "uitofp") \
- X(Sitofp, "sitofp") \
+#define ICEINSTCAST_TABLE \
+ /* enum value, printable string */ \
+ X(Trunc, "trunc") \
+ X(Zext, "zext") \
+ X(Sext, "sext") \
+ X(Fptrunc, "fptrunc") \
+ X(Fpext, "fpext") \
+ X(Fptoui, "fptoui") \
+ X(Fptosi, "fptosi") \
+ X(Uitofp, "uitofp") \
+ X(Sitofp, "sitofp") \
X(Bitcast, "bitcast")
//#define X(tag, str)
-#define ICEINSTFCMP_TABLE \
- /* enum value, printable string */ \
- X(False, "false") \
- X(Oeq, "oeq") \
- X(Ogt, "ogt") \
- X(Oge, "oge") \
- X(Olt, "olt") \
- X(Ole, "ole") \
- X(One, "one") \
- X(Ord, "ord") \
- X(Ueq, "ueq") \
- X(Ugt, "ugt") \
- X(Uge, "uge") \
- X(Ult, "ult") \
- X(Ule, "ule") \
- X(Une, "une") \
- X(Uno, "uno") \
+#define ICEINSTFCMP_TABLE \
+ /* enum value, printable string */ \
+ X(False, "false") \
+ X(Oeq, "oeq") \
+ X(Ogt, "ogt") \
+ X(Oge, "oge") \
+ X(Olt, "olt") \
+ X(Ole, "ole") \
+ X(One, "one") \
+ X(Ord, "ord") \
+ X(Ueq, "ueq") \
+ X(Ugt, "ugt") \
+ X(Uge, "uge") \
+ X(Ult, "ult") \
+ X(Ule, "ule") \
+ X(Une, "une") \
+ X(Uno, "uno") \
X(True, "true")
//#define X(tag, str)
-#define ICEINSTICMP_TABLE \
- /* enum value, printable string */ \
- X(Eq, "eq") \
- X(Ne, "ne") \
- X(Ugt, "ugt") \
- X(Uge, "uge") \
- X(Ult, "ult") \
- X(Ule, "ule") \
- X(Sgt, "sgt") \
- X(Sge, "sge") \
- X(Slt, "slt") \
- X(Sle, "sle")
-//#define X(tag, str)
+#define ICEINSTICMP_TABLE \
+ /* enum value, reverse, printable string */ \
+ X(Eq, InstIcmp::ICond::Eq, "eq") \
Jim Stichnoth 2016/07/20 22:25:56 I think you should remove all the "InstIcmp::ICond
manasijm 2016/07/20 22:54:17 Done.
+ X(Ne, InstIcmp::ICond::Ne, "ne") \
+ X(Ugt, InstIcmp::ICond::Ult, "ugt") \
+ X(Uge, InstIcmp::ICond::Ule, "uge") \
+ X(Ult, InstIcmp::ICond::Ugt, "ult") \
+ X(Ule, InstIcmp::ICond::Uge, "ule") \
+ X(Sgt, InstIcmp::ICond::Slt, "sgt") \
+ X(Sge, InstIcmp::ICond::Sle, "sge") \
+ X(Slt, InstIcmp::ICond::Sgt, "slt") \
+ X(Sle, InstIcmp::ICond::Sge, "sle")
+//#define X(tag, reverse, str)
#endif // SUBZERO_SRC_ICEINST_DEF
« src/IceCfg.h ('K') | « src/IceInst.cpp ('k') | src/IceTargetLowering.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698