third_party/WebKit/Source/platform/scroll/ScrollableArea.cpp - Issue 2124973004: ScrollableArea should update scrollAnimator with clamped position.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/scroll/ScrollableArea.cpp

Issue 2124973004: ScrollableArea should update scrollAnimator with clamped position. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use clamped but non-truncated position during ScrollableArea update. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/platform/scroll/ScrollableArea.cpp

diff --git a/third_party/WebKit/Source/platform/scroll/ScrollableArea.cpp b/third_party/WebKit/Source/platform/scroll/ScrollableArea.cpp

index 5a15ad7de6be60c755e888a7db77c1cde662a3de..24273cc49da22cfedde27cf7e9979ef86e00cdd9 100644

--- a/third_party/WebKit/Source/platform/scroll/ScrollableArea.cpp

+++ b/third_party/WebKit/Source/platform/scroll/ScrollableArea.cpp

@@ -282,7 +282,7 @@ void ScrollableArea::scrollPositionChanged(const DoublePoint& position, ScrollTy

scrollAnimator().notifyContentAreaScrolled(toFloatSize(scrollPositionDouble() - oldPosition));

}

- scrollAnimator().setCurrentPosition(toFloatPoint(position));

+ scrollAnimator().setCurrentPosition(toFloatPoint(clampScrollPosition(position)));

}

bool ScrollableArea::scrollBehaviorFromString(const String& behaviorString, ScrollBehavior& behavior)

« no previous file with comments | « no previous file | no next file » | no next file with comments »