These are the database objects used while finding the regression range. 1/3

appengine/findit/model/flake/test/master_flake_analysis_test.py

Index: appengine/findit/model/flake/test/master_flake_analysis_test.py
diff --git a/appengine/findit/model/flake/test/master_flake_analysis_test.py b/appengine/findit/model/flake/test/master_flake_analysis_test.py
new file mode 100644
index 0000000000000000000000000000000000000000..024eacc9315f53fe9a6d2ef5203f99b30edc7d46
--- /dev/null
+++ b/appengine/findit/model/flake/test/master_flake_analysis_test.py
@@ -0,0 +1,77 @@
+# Copyright 2016 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+from datetime import datetime
+
+import unittest
+
+from model import analysis_status
+from model.flake.master_flake_analysis import MasterFlakeAnalysis
+
+
+class MasterFlakeAnalysisTest(unittest.TestCase):
+
+  def testMasterFlakeAnalysisStatusIsCompleted(self):
+    for status in (analysis_status.COMPLETED, analysis_status.ERROR):
+      analysis = MasterFlakeAnalysis.Create('m', 'b', 123, 's', 't')
+      analysis.status = status
+      self.assertTrue(analysis.completed)
+
+  def testMasterFlakeAnalysisStatusIsNotCompleted(self):
+    for status in (analysis_status.PENDING, analysis_status.RUNNING):
+      analysis = MasterFlakeAnalysis.Create('m', 'b', 123, 's', 't')
+      analysis.status = status
+      self.assertFalse(analysis.completed)
+
+  def testMasterFlakeAnalysisDurationWhenNotCompleted(self):
+    analysis = MasterFlakeAnalysis.Create('m', 'b', 123, 's', 't')
+    analysis.status = analysis_status.RUNNING
+    self.assertIsNone(analysis.duration)
+
+  def testMasterFlakeAnalysisDurationWhenStartTimeNotSet(self):
+    analysis = MasterFlakeAnalysis.Create('m', 'b', 123, 's', 't')
+    analysis.status = analysis_status.COMPLETED
+    analysis.end_time = datetime(2015, 07, 30, 21, 15, 30, 40)
+    self.assertIsNone(analysis.duration)
+
+  def testMasterFlakeAnalysisDurationWhenEndTimeNotSet(self):
+    analysis = MasterFlakeAnalysis.Create('m', 'b', 123, 's', 't')
+    analysis.status = analysis_status.COMPLETED
+    analysis.start_time = datetime(2015, 07, 30, 21, 15, 30, 40)
+    self.assertIsNone(analysis.duration)
+
+  def testMasterFlakeAnalysisDurationWhenCompleted(self):
+    analysis = MasterFlakeAnalysis.Create('m', 'b', 123, 's', 't')
+    analysis.status = analysis_status.COMPLETED
+    analysis.start_time = datetime(2015, 07, 30, 21, 15, 30, 40)
+    analysis.end_time = datetime(2015, 07, 30, 21, 16, 15, 50)
+    self.assertEqual(45, analysis.duration)
+
+  def testMasterFlakeAnalysisStatusIsFailed(self):
+    analysis = MasterFlakeAnalysis.Create('m', 'b', 123, 's', 't')
+    analysis.status = analysis_status.ERROR
+    self.assertTrue(analysis.failed)
+
+  def testMasterFlakeAnalysisStatusIsNotFailed(self):
+    for status in (analysis_status.PENDING, analysis_status.RUNNING,
+                   analysis_status.COMPLETED):
+      analysis = MasterFlakeAnalysis.Create('m', 'b', 123, 's', 't')
+      analysis.status = status
+      self.assertFalse(analysis.failed)
+
+  def testMasterFlakeAnalysisStatusDescription(self):
+    analysis = MasterFlakeAnalysis.Create('m', 'b', 123, 's', 't')
+    analysis.status = analysis_status.PENDING

[lijeffrey, 2016/07/27 21:28:30]

you're going to hate me for this but this test looks like it should be broken
into separate tests

usually if a test is a 1-liner you can bundle several of them in 1 test,

i.e.

testAdd(self):
  self.assertEqual(0, add(0, 0))
  self.assertEqual(1, add(0, 1))
  self.assertEqual(1, add (2, -1))
  ...

but in this case each combination needs a slightly different setup, so break
this down into separate tests in case any 1 of them is broken it's easy to tell
which combination broke

+    self.assertEqual('Pending', analysis.status_description)
+    analysis.status = analysis_status.RUNNING
+    self.assertEqual('Running', analysis.status_description)
+    analysis.status = analysis_status.COMPLETED
+    self.assertEqual('Completed', analysis.status_description)
+    analysis.status = analysis_status.ERROR
+    self.assertEqual('Error', analysis.status_description)
+
+  def testMasterFlakeAnalysisStepTestName(self):
+    analysis = MasterFlakeAnalysis.Create('m', 'b', 123, 's', 't')
+    self.assertEqual('s', analysis.step_name)
+    self.assertEqual('t', analysis.test_name)