Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1732)

Unified Diff: appengine/findit/model/flake/base_analysis.py

Issue 2124973003: These are the database objects used while finding the regression range. 1/3 (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/model/flake/base_analysis.py
diff --git a/appengine/findit/model/wf_analysis.py b/appengine/findit/model/flake/base_analysis.py
similarity index 65%
copy from appengine/findit/model/wf_analysis.py
copy to appengine/findit/model/flake/base_analysis.py
index 2838adea93c03ac67cdba4ecd42d05e4cdaf226f..4206407d9cda1d7aeba8fcaa891b188d159e5aec 100644
--- a/appengine/findit/model/wf_analysis.py
+++ b/appengine/findit/model/flake/base_analysis.py
@@ -11,25 +11,9 @@ from model import analysis_status
from model import result_status
-class WfAnalysis(BaseBuildModel):
+class BaseAnalysis(BaseBuildModel):
"""Represents an analysis of a build of a builder in a Chromium waterfall.
-
- 'Wf' is short for waterfall.
"""
- @staticmethod
- def _CreateKey(master_name, builder_name, build_number): # pragma: no cover
- return ndb.Key('WfAnalysis',
- BaseBuildModel.CreateBuildId(
- master_name, builder_name, build_number))
-
- @staticmethod
- def Create(master_name, builder_name, build_number): # pragma: no cover
- return WfAnalysis(
- key=WfAnalysis._CreateKey(master_name, builder_name, build_number))
-
- @staticmethod
- def Get(master_name, builder_name, build_number): # pragma: no cover
- return WfAnalysis._CreateKey(master_name, builder_name, build_number).get()
@property
def completed(self):
@@ -115,16 +99,9 @@ class WfAnalysis(BaseBuildModel):
def failure_type_str(self):
stgao 2016/07/08 22:51:27 Same here.
caiw 2016/07/14 00:59:39 Done.
return failure_type.GetDescriptionForFailureType(self.failure_type)
- # When the build cycle started.
- build_start_time = ndb.DateTimeProperty(indexed=True)
- # Whether the build cycle has completed.
- build_completed = ndb.BooleanProperty(indexed=False)
- # Whether it is a compile failure, test failure, infra failure or others.
- # Refer to common/waterfall/failure_type.py for all the failure types.
- build_failure_type = ndb.IntegerProperty(indexed=False)
-
# The url path to the pipeline status page.
pipeline_status_path = ndb.StringProperty(indexed=False)
+
# The status of the analysis.
status = ndb.IntegerProperty(
default=analysis_status.PENDING, indexed=False)
@@ -138,18 +115,3 @@ class WfAnalysis(BaseBuildModel):
updated_time = ndb.DateTimeProperty(indexed=False, auto_now=True)
# Record which version of analysis.
version = ndb.StringProperty(indexed=False)
-
- # Analysis result for the build failure.
- not_passed_steps = ndb.StringProperty(indexed=False, repeated=True)
- result = ndb.JsonProperty(indexed=False, compressed=True)
- # Suspected CLs we found.
- suspected_cls = ndb.JsonProperty(indexed=False, compressed=True)
- # Record the id of try job results of each failure.
- failure_result_map = ndb.JsonProperty(indexed=False, compressed=True)
-
- # The actual culprit CLs that are responsible for the failures.
- culprit_cls = ndb.JsonProperty(indexed=False, compressed=True)
- # Conclusion of analysis result for the build failure: 'Found' or 'Not Found'.
- result_status = ndb.IntegerProperty(indexed=True)
- # Record the history of triage.
- triage_history = ndb.JsonProperty(indexed=False, compressed=True)

Powered by Google App Engine
This is Rietveld 408576698