These are the database objects used while finding the regression range. 1/3

appengine/findit/model/flake/flake_swarming_task_result.py

+# Copyright 2014 The Chromium Authors. All rights reserved.

[chanli, 2016/07/07 23:38:28]

2014 -> 2016

[caiw, 2016/07/14 00:59:40]

Done.

+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+from google.appengine.ext import ndb
+
+from common import constants
+from model import analysis_status
+
+class FlakeSwarmingTaskResult(ndb.Model):
+  """Results of a swarming task for a single suspected flaky test.
+  """
+
+  @staticmethod
+  def CreateAnalysisId(master_name, builder_name,
+                       step_name, build_number, testname):  # pragma: no cover

[chanli, 2016/07/07 23:38:28]

nit: I would use test_name instead of testname

[caiw, 2016/07/14 00:59:40]

Done.

+    return '%s/%s/%s/%s/%s' % (master_name, builder_name,
+                               step_name, build_number, testname)
+
+  @staticmethod
+  def _CreateKey(master_name, builder_name,
+                 step_name, build_number, testname):  # pragma: no cover
+    return ndb.Key('FlakeSwarmingTaskResult',
+                   FlakeSwarmingTaskResult.CreateAnalysisId(
+                       master_name, builder_name, step_name,
+                       build_number, testname))
+
+  @staticmethod
+  def Create(master_name, builder_name,
+             step_name, build_number, testname):  # pragma: no cover
+    return FlakeSwarmingTaskResult(key=FlakeSwarmingTaskResult._CreateKey(
+            master_name, builder_name, step_name, build_number, testname))
+
+  @staticmethod
+  def Get(master_name, builder_name,
+          step_name, build_number, testname):  # pragma: no cover
+    return FlakeSwarmingTaskResult._CreateKey(
+        master_name, builder_name, step_name, build_number, testname).get()
+
+
+  @property
+  def completed(self):
+    return self.status in (
+        analysis_status.COMPLETED, analysis_status.ERROR)
+
+  @property
+  def failed(self):
+    return self.status == analysis_status.ERROR
+
+  @property
+  def status_description(self):
+    return analysis_status.STATUS_TO_DESCRIPTION.get(self.status, 'Unknown')
+
+  @ndb.ComputedProperty
+  def master_name(self):
+    return self.key.pairs()[0][1].split('/')[0]

[stgao, 2016/07/08 22:51:27]

As we discussed, some code here could be cleaned up a bit after using some
BaseBuildModel class.

[caiw, 2016/07/14 00:59:40]

Done.

+
+  @ndb.ComputedProperty
+  def builder_name(self):
+    return self.key.pairs()[0][1].split('/')[1]
+
+  @ndb.ComputedProperty
+  def step_name(self):
+    return self.key.pairs()[0][1].split('/')[2]
+
+  @ndb.ComputedProperty
+  def build_number(self):
+    return int(self.key.pairs()[0][1].split('/')[3])
+
+  @ndb.ComputedProperty
+  def test_name(self):
+    return self.key.pairs()[0][1].split('/')[4]
+
+

[chanli, 2016/07/07 23:38:28]

Same here: please add comments.

[caiw, 2016/07/14 00:59:40]

Done.

+  status = ndb.IntegerProperty(default=analysis_status.PENDING, indexed=False)
+  successes = ndb.IntegerProperty(default=0, indexed=False)
+  tries = ndb.IntegerProperty(default=0, indexed=False)
+  git_hash = ndb.StringProperty(indexed=False)
+  commit_position = ndb.IntegerProperty(indexed=False)
+  master_name = ndb.StringProperty(indexed=False)