These are the database objects used while finding the regression range. 1/3

appengine/findit/model/base_flake_model.py

 # Copyright 2014 The Chromium Authors. All rights reserved.

[chanli, 2016/07/07 23:38:27]

nit: change the year to 2016, same for others

[caiw, 2016/07/14 00:59:39]

Done.

 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from google.appengine.ext import ndb
 
 
-class BaseBuildModel(ndb.Model):  # pragma: no cover
+class BaseFlakeModel(ndb.Model):  # pragma: no cover
   """A base class to provide computed properties from the key.
 
   The computed properties are master name, builder name, and build number.

[chanli, 2016/07/07 23:38:27]

Please change the docstring here: step_name is also used here.

   Subclasses should set its key as:
     build_id = BaseBuildModel.CreateBuildId(
         master_name, builder_name, build_number)
     ndb.Key('KindName', build_id, 'Optional_KindName', optional_id, ...)

[chanli, 2016/07/07 23:38:27]

Please update this part

[caiw, 2016/07/14 00:59:39]

Done.

   """
 
   @staticmethod
-  def CreateBuildId(master_name, builder_name, build_number):
-    return '%s/%s/%s' % (master_name, builder_name, build_number)
+  def CreateFlakeId(master_name, builder_name, step_name, build_number):

[chanli, 2016/07/07 23:38:28]

I would have the argument list as :
master_name, builder_name, build_number, step_name

[caiw, 2016/07/14 00:59:39]

Done.

+    return '%s/%s/%s/%s' % (master_name, builder_name, step_name, build_number)

[chanli, 2016/07/07 23:38:28]

Is there a reason why you want to organize the key like this? I would use
(master_name, builder_name, build_number, step_name) since first 3 are for build
and step_name is for step in the build

[caiw, 2016/07/14 00:59:39]

Done.

 
   @ndb.ComputedProperty
   def master_name(self):

[stgao, 2016/07/08 22:51:26]

Per discussion, we will use the BaseBuildModel directly.

[caiw, 2016/07/14 00:59:39]

Done.

     return self.key.pairs()[0][1].split('/')[0]
 
   @ndb.ComputedProperty
   def builder_name(self):
     return self.key.pairs()[0][1].split('/')[1]
 
   @ndb.ComputedProperty
+  def step_name(self):
+    return self.key.pairs()[0][1].split('/')[2]
+
+  @ndb.ComputedProperty
   def build_number(self):
-    return int(self.key.pairs()[0][1].split('/')[2])
+    return int(self.key.pairs()[0][1].split('/')[3]
+)