Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(994)

Unified Diff: chrome/browser/ui/webui/ntp/ntp_user_data_logger_unittest.cc

Issue 2124953004: Remove a bunch of broken/unused/non-useful NTP UMA histograms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/ntp/ntp_user_data_logger.cc ('k') | chrome/common/search/ntp_logging_events.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/ntp/ntp_user_data_logger_unittest.cc
diff --git a/chrome/browser/ui/webui/ntp/ntp_user_data_logger_unittest.cc b/chrome/browser/ui/webui/ntp/ntp_user_data_logger_unittest.cc
index 759125e1420b0cfdb88e2a43771ae77460956699..dbdedebf18469d0a88e1338a7d71ea91477bb29e 100644
--- a/chrome/browser/ui/webui/ntp/ntp_user_data_logger_unittest.cc
+++ b/chrome/browser/ui/webui/ntp/ntp_user_data_logger_unittest.cc
@@ -50,47 +50,16 @@ TEST_F(NTPUserDataLoggerTest, TestLogging) {
for (int i = 0; i < 8; ++i)
logger.LogEvent(NTP_TILE, delta);
- for (int i = 0; i < 4; ++i)
- logger.LogEvent(NTP_THUMBNAIL_TILE, delta);
- for (int i = 0; i < 2; ++i)
- logger.LogEvent(NTP_THUMBNAIL_ERROR, delta);
- logger.LogEvent(NTP_GRAY_TILE_FALLBACK, delta);
- logger.LogEvent(NTP_EXTERNAL_TILE_FALLBACK, delta);
- for (int i = 0; i < 2; ++i)
- logger.LogEvent(NTP_EXTERNAL_TILE, delta);
- for (int i = 0; i < 2; ++i)
- logger.LogEvent(NTP_GRAY_TILE, delta);
logger.LogEvent(NTP_SERVER_SIDE_SUGGESTION, delta);
logger.EmitNtpStatistics(NTPUserDataLogger::EmitReason::NAVIGATED_AWAY);
EXPECT_EQ(1, GetTotalCount("NewTabPage.NumberOfTiles"));
EXPECT_EQ(1, GetBinCount("NewTabPage.NumberOfTiles", 8));
- EXPECT_EQ(1, GetTotalCount("NewTabPage.NumberOfThumbnailTiles"));
- EXPECT_EQ(1, GetBinCount("NewTabPage.NumberOfThumbnailTiles", 4));
- EXPECT_EQ(1, GetTotalCount("NewTabPage.NumberOfThumbnailErrors"));
- EXPECT_EQ(1, GetBinCount("NewTabPage.NumberOfThumbnailErrors", 2));
- EXPECT_EQ(1, GetTotalCount("NewTabPage.NumberOfGrayTileFallbacks"));
- EXPECT_EQ(1, GetBinCount("NewTabPage.NumberOfGrayTileFallbacks", 1));
- EXPECT_EQ(1, GetTotalCount("NewTabPage.NumberOfExternalTileFallbacks"));
- EXPECT_EQ(1, GetBinCount("NewTabPage.NumberOfExternalTileFallbacks", 1));
- EXPECT_EQ(1, GetTotalCount("NewTabPage.NumberOfExternalTiles"));
- EXPECT_EQ(1, GetBinCount("NewTabPage.NumberOfExternalTiles", 2));
- EXPECT_EQ(1, GetTotalCount("NewTabPage.NumberOfGrayTiles"));
- EXPECT_EQ(1, GetBinCount("NewTabPage.NumberOfGrayTiles", 2));
- EXPECT_EQ(1, GetTotalCount("NewTabPage.SuggestionsType"));
- EXPECT_EQ(1, GetBinCount("NewTabPage.SuggestionsType", 1));
// Statistics should be reset to 0, so we should not log anything else.
logger.EmitNtpStatistics(NTPUserDataLogger::EmitReason::NAVIGATED_AWAY);
EXPECT_EQ(1, GetTotalCount("NewTabPage.NumberOfTiles"));
- EXPECT_EQ(1, GetTotalCount("NewTabPage.NumberOfThumbnailTiles"));
- EXPECT_EQ(1, GetTotalCount("NewTabPage.NumberOfThumbnailErrors"));
- EXPECT_EQ(1, GetTotalCount("NewTabPage.NumberOfGrayTileFallbacks"));
- EXPECT_EQ(1, GetTotalCount("NewTabPage.NumberOfExternalTileFallbacks"));
- EXPECT_EQ(1, GetTotalCount("NewTabPage.NumberOfExternalTiles"));
- EXPECT_EQ(1, GetTotalCount("NewTabPage.NumberOfGrayTiles"));
- EXPECT_EQ(1, GetTotalCount("NewTabPage.SuggestionsType"));
}
TEST_F(NTPUserDataLoggerTest, TestLogMostVisitedImpression) {
« no previous file with comments | « chrome/browser/ui/webui/ntp/ntp_user_data_logger.cc ('k') | chrome/common/search/ntp_logging_events.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698