Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(834)

Unified Diff: chrome/browser/ui/webui/ntp/ntp_user_data_logger.h

Issue 2124953004: Remove a bunch of broken/unused/non-useful NTP UMA histograms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/ntp/ntp_user_data_logger.h
diff --git a/chrome/browser/ui/webui/ntp/ntp_user_data_logger.h b/chrome/browser/ui/webui/ntp/ntp_user_data_logger.h
index 7150ce86d9c08b68d1bc4a20adbb49d097220629..6e6f965b058ad9fab999be97fa0a462f5c26fb1a 100644
--- a/chrome/browser/ui/webui/ntp/ntp_user_data_logger.h
+++ b/chrome/browser/ui/webui/ntp/ntp_user_data_logger.h
@@ -7,11 +7,8 @@
#include <stddef.h>
-#include <string>
-
#include "base/gtest_prod_util.h"
#include "base/macros.h"
-#include "base/strings/string16.h"
#include "base/time/time.h"
#include "chrome/common/search/ntp_logging_events.h"
#include "content/public/browser/web_contents_observer.h"
@@ -42,10 +39,6 @@ class NTPUserDataLogger
// Logs a navigation on one of the NTP tiles by a given source.
void LogMostVisitedNavigation(int position, NTPLoggingTileSource tile_source);
- // content::WebContentsObserver override
- void NavigationEntryCommitted(
- const content::LoadCommittedDetails& load_details) override;
-
// Called when the tab is closed. Logs statistics.
void TabDeactivated();
@@ -65,6 +58,10 @@ class NTPUserDataLogger
FRIEND_TEST_ALL_PREFIXES(NTPUserDataLoggerTest,
TestLogging);
+ // content::WebContentsObserver override
+ void NavigationEntryCommitted(
+ const content::LoadCommittedDetails& load_details) override;
+
// To clarify at the call site whether we are calling EmitNtpStatistics() for
// a good reason (CLOSED, NAVIGATED_AWAY) or a questionable one (MV_CHANGED,
// INTERNAL_FLUSH).
@@ -86,30 +83,6 @@ class NTPUserDataLogger
// or an external tile.
size_t number_of_tiles_;
- // Total number of tiles using a local thumbnail image for this NTP session.
- size_t number_of_thumbnail_tiles_;
-
- // Total number of tiles for which no thumbnail is specified and a gray tile
- // with the domain is used as the main tile.
- size_t number_of_gray_tiles_;
-
- // Total number of tiles for which the visual appearance is handled externally
- // by the page itself.
- size_t number_of_external_tiles_;
-
- // Total number of errors that occurred when trying to load thumbnail images
- // for this NTP session. When these errors occur a grey tile is shown instead
- // of a thumbnail image.
- size_t number_of_thumbnail_errors_;
-
- // The number of times a gray tile with the domain was used as the fallback
- // for a failed thumbnail.
- size_t number_of_gray_tile_fallbacks_;
-
- // The number of times an external tile, for which the visual appearance is
- // handled by the page itself, was the fallback for a failed thumbnail.
- size_t number_of_external_tile_fallbacks_;
-
// Time from navigation start it took to load the NTP in milliseconds.
base::TimeDelta load_time_;
« no previous file with comments | « chrome/browser/resources/local_ntp/most_visited_util.js ('k') | chrome/browser/ui/webui/ntp/ntp_user_data_logger.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698