Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: chrome/browser/resources/local_ntp/most_visited_thumbnail.js

Issue 2124953004: Remove a bunch of broken/unused/non-useful NTP UMA histograms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/local_ntp/most_visited_thumbnail.js
diff --git a/chrome/browser/resources/local_ntp/most_visited_thumbnail.js b/chrome/browser/resources/local_ntp/most_visited_thumbnail.js
index bf74b6ee6b2a8a46925c0b9b870fb8418b5c6e2e..4c83e8a26946a8d21a07796fa5982e83d1e2bdc1 100644
--- a/chrome/browser/resources/local_ntp/most_visited_thumbnail.js
+++ b/chrome/browser/resources/local_ntp/most_visited_thumbnail.js
@@ -60,12 +60,9 @@ window.addEventListener('DOMContentLoaded', function() {
// If no external thumbnail fallback (etfb), and have domain.
if (!params.etfb && data.domain) {
showDomainElement();
- logEvent(NTP_LOGGING_EVENT_TYPE.NTP_GRAY_TILE_FALLBACK);
} else {
showEmptyTile();
- logEvent(NTP_LOGGING_EVENT_TYPE.NTP_EXTERNAL_TILE_FALLBACK);
}
- logEvent(NTP_LOGGING_EVENT_TYPE.NTP_THUMBNAIL_ERROR);
logEvent(NTP_LOGGING_EVENT_TYPE.NTP_TILE_LOADED);
};
image.src = src;
@@ -74,19 +71,15 @@ window.addEventListener('DOMContentLoaded', function() {
var useIcons = params['icons'] == '1';
if (data.dummy) {
showEmptyTile();
- logEvent(NTP_LOGGING_EVENT_TYPE.NTP_EXTERNAL_TILE);
} else if (useIcons && data.largeIconUrl) {
createThumbnail(data.largeIconUrl, 'large-icon');
// TODO(huangs): Log event for large icons.
} else if (!useIcons && data.thumbnailUrls && data.thumbnailUrls.length) {
createThumbnail(data.thumbnailUrls[0], 'thumbnail');
- logEvent(NTP_LOGGING_EVENT_TYPE.NTP_THUMBNAIL_TILE);
} else if (data.domain) {
showDomainElement();
- logEvent(NTP_LOGGING_EVENT_TYPE.NTP_GRAY_TILE);
} else {
showEmptyTile();
- logEvent(NTP_LOGGING_EVENT_TYPE.NTP_EXTERNAL_TILE);
}
logEvent(NTP_LOGGING_EVENT_TYPE.NTP_TILE);
« no previous file with comments | « chrome/browser/resources/local_ntp/most_visited_single.js ('k') | chrome/browser/resources/local_ntp/most_visited_util.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698