Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4742)

Unified Diff: chrome/browser/resources/local_ntp/most_visited_single.js

Issue 2124953004: Remove a bunch of broken/unused/non-useful NTP UMA histograms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/local_ntp/most_visited_thumbnail.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/local_ntp/most_visited_single.js
diff --git a/chrome/browser/resources/local_ntp/most_visited_single.js b/chrome/browser/resources/local_ntp/most_visited_single.js
index c10cd549ecbbd5f46ef1129b46a909e8626cb9c9..817fd76b0dc1c4c7583f9d10655030e57cf16ff6 100644
--- a/chrome/browser/resources/local_ntp/most_visited_single.js
+++ b/chrome/browser/resources/local_ntp/most_visited_single.js
@@ -23,11 +23,6 @@ var LOG_TYPE = {
// Indicates a tile was rendered, no matter if it's a thumbnail, a gray tile
// or an external tile.
NTP_TILE: 2,
- // The tile uses a local thumbnail image.
- NTP_THUMBNAIL_TILE: 3,
- // There was an error in loading both the thumbnail image and the fallback
- // (if it was provided), resulting in a gray tile.
- NTP_THUMBNAIL_ERROR: 6,
// A NTP Tile has finished loading (successfully or failing).
NTP_TILE_LOADED: 10,
};
@@ -470,10 +465,8 @@ var renderTile = function(data) {
img.addEventListener('error', function(ev) {
thumb.classList.add('failed-img');
thumb.removeChild(img);
- logEvent(LOG_TYPE.NTP_THUMBNAIL_ERROR);
});
thumb.appendChild(img);
- logEvent(LOG_TYPE.NTP_THUMBNAIL_TILE);
} else {
thumb.classList.add('failed-img');
}
@@ -506,7 +499,6 @@ var renderTile = function(data) {
}
thumb.classList.add('failed-img');
thumb.removeChild(img);
- logEvent(LOG_TYPE.NTP_THUMBNAIL_ERROR);
countLoad();
};
@@ -532,10 +524,8 @@ var renderTile = function(data) {
img.addEventListener('error', function(ev) {
thumb.classList.add('failed-img');
thumb.removeChild(img);
- logEvent(LOG_TYPE.NTP_THUMBNAIL_ERROR);
});
thumb.appendChild(img);
- logEvent(LOG_TYPE.NTP_THUMBNAIL_TILE);
if (data.thumbnailUrl) {
img.src = data.thumbnailUrl;
« no previous file with comments | « no previous file | chrome/browser/resources/local_ntp/most_visited_thumbnail.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698