Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issue 2124953002: save vertex attribute divisor values for each program (Closed)

Created:
4 years, 5 months ago by xinghua.cao
Modified:
4 years, 5 months ago
Reviewers:
yunchao, qiankun
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

If there are two shader programs, one vertex attribute's divisor of the first program is non-zero, other vertex attribute's divisor of the second program is zero, when the two vetext attributes' location value is the same. the latter vertex attribute's divisor value is non-zero, and override by the former one. So save vertex attribute divisor values in program instead of vertex attribute manager. BUG=625960 TEST=all/deqp/functional/gles3/instancedrendering.html CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Patch Set 1 #

Patch Set 2 : Only need to save vertex attrib values for each program #

Patch Set 3 : Remove non used code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -1 line) Patch
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/program_manager.h View 1 2 chunks +16 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/program_manager.cc View 1 2 chunks +7 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/vertex_attrib_manager.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 19 (12 generated)
xinghua.cao
Please help to review it, thank you.
4 years, 5 months ago (2016-07-07 02:47:41 UTC) #5
qiankun
On 2016/07/07 02:47:41, xinghua.cao wrote: > Please help to review it, thank you. Can you ...
4 years, 5 months ago (2016-07-07 06:41:31 UTC) #6
yunchao
On 2016/07/07 06:41:31, qiankun wrote: > On 2016/07/07 02:47:41, xinghua.cao wrote: > > Please help ...
4 years, 5 months ago (2016-07-07 10:33:34 UTC) #8
xinghua.cao
On 2016/07/07 10:33:34, yunchao wrote: > On 2016/07/07 06:41:31, qiankun wrote: > > On 2016/07/07 ...
4 years, 5 months ago (2016-07-07 10:40:29 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2124953002/1
4 years, 5 months ago (2016-07-07 10:49:45 UTC) #11
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/99845)
4 years, 5 months ago (2016-07-07 11:22:08 UTC) #13
qiankun
4 years, 5 months ago (2016-07-20 10:04:22 UTC) #19
Can we close this now since it was fixed in WebGL conformance test:
https://github.com/KhronosGroup/WebGL/pull/1906.

Powered by Google App Engine
This is Rietveld 408576698