Issue 212493003: Fix the print of the rebase error message, and make the output prettier too.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 212493003: Fix the print of the rebase error message, and make the output prettier too. (Closed)

Created:
6 years, 9 months ago by iannucci

Modified:
6 years, 9 months ago

Reviewers:
agable

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

Fix the print of the rebase error message, and make the output prettier too. For some reason .output doesn't throw an AttributeError, but returns None , instead. .stdout is the correct attribute. R=agable@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=259695

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	git_common.py	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	git_rebase_update.py	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Total messages: 5 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/iannucci@chromium.org/212493003/1

6 years, 9 months ago (2014-03-26 21:21:33 UTC) #4

Message was sent while issue was closed.

Change committed as 259695