Issue 212493002: Make udiff print reasonable errors while not on a branch.

Issue 212493002: Make udiff print reasonable errors while not on a branch. (Closed)

Created:
6 years, 9 months ago by iannucci

Modified:
6 years, 9 months ago

Reviewers:
agable

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

Description

Make udiff print reasonable errors while not on a branch. R=agable@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=259647

Patch Set 2 : fix comments #

Created: 6 years, 9 months ago

		Unified diffs	Side-by-side diffs	Stats (+14 lines, -5 lines)
	M	git_upstream_diff.py	View	2 chunks	+14 lines, -5 lines	0 comments

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

agable

LGTM https://codereview.chromium.org/212493002/diff/1/git_upstream_diff.py File git_upstream_diff.py (right): https://codereview.chromium.org/212493002/diff/1/git_upstream_diff.py#newcode11 git_upstream_diff.py:11: from git_common import current_branch, get_or_create_merge_base, config_list Would be ...

6 years, 9 months ago (2014-03-26 15:36:24 UTC) #2

iannucci

https://chromiumcodereview.appspot.com/212493002/diff/1/git_upstream_diff.py File git_upstream_diff.py (right): https://chromiumcodereview.appspot.com/212493002/diff/1/git_upstream_diff.py#newcode11 git_upstream_diff.py:11: from git_common import current_branch, get_or_create_merge_base, config_list On 2014/03/26 15:36:24, ...

6 years, 9 months ago (2014-03-26 18:51:10 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/iannucci@chromium.org/212493002/50001

6 years, 9 months ago (2014-03-26 18:53:34 UTC) #5

Message was sent while issue was closed.

Change committed as 259647

Expand Messages | Collapse Messages