[SPv2] Use foreign layer support to enable composited video.

[SPv2] Use foreign layer support to enable composited video.

YouTube videos now play with --enable-slimming-paint-v2 --enable-layer-lists.

BUG=587970
Committed: https://crrev.com/9da7614d2c771b7c9f4b47e24f514480c32def78
Cr-Commit-Position: refs/heads/master@{#404259}

[jbroman, 2016-07-05 21:33:35]

jbroman@chromium.org changed reviewers:
+ pdr@chromium.org, trchen@chromium.org

[pdr., 2016-07-06 23:30:37]

Auto-LGTM for improving cat videos.

LGTM with or without the suggestion below.

https://codereview.chromium.org/2124893002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/paint/VideoPainter.cpp (right):

https://codereview.chromium.org/2124893002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/paint/VideoPainter.cpp:53: recordForeignLayer(
Wdyt about changing recordForeignLayer to take an IntRect? The other caller in
WebPluginContainerImpl could then pass in frameRect() instead of location() and
size().

[pdr., 2016-07-06 23:31:25]

On 2016/07/06 at 23:30:37, pdr. wrote:
> Auto-LGTM for improving cat videos.
> 
> LGTM with or without the suggestion below.
> 
>
https://codereview.chromium.org/2124893002/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/paint/VideoPainter.cpp (right):
> 
>
https://codereview.chromium.org/2124893002/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/paint/VideoPainter.cpp:53: recordForeignLayer(
> Wdyt about changing recordForeignLayer to take an IntRect? The other caller in
WebPluginContainerImpl could then pass in frameRect() instead of location() and
size().

Thinking about this more, don't do this suggestion. It is a bad suggestion.

[pdr., 2016-07-06 23:36:41]

Thinking about this more... can you add an integration test for this?

[jbroman, 2016-07-07 18:01:32]

Patchset #2 (id:20001) has been deleted

[jbroman, 2016-07-07 18:05:52]

On 2016/07/06 at 23:36:41, pdr wrote:
> Thinking about this more... can you add an integration test for this?

Ask and ye shall receive.

[jbroman, 2016-07-07 18:10:42]

Patchset #2 (id:40001) has been deleted

[pdr., 2016-07-07 20:44:11]

On 2016/07/07 at 18:05:52, jbroman wrote:
> On 2016/07/06 at 23:36:41, pdr wrote:
> > Thinking about this more... can you add an integration test for this?
> 
> Ask and ye shall receive.

Wow that was a lot more work than I expected. Thanks!

LGTM

[jbroman, 2016-07-07 20:45:39]

The CQ bit was checked by jbroman@chromium.org

[commit-bot: I haz the power, 2016-07-07 20:46:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-07 22:22:46]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2016-07-07 22:23:09]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-07 22:25:34]

Description was changed from

==========
[SPv2] Use foreign layer support to enable composited video.

YouTube videos now play with --enable-slimming-paint-v2 --enable-layer-lists.

BUG=587970
==========

to

==========
[SPv2] Use foreign layer support to enable composited video.

YouTube videos now play with --enable-slimming-paint-v2 --enable-layer-lists.

BUG=587970

Committed: https://crrev.com/9da7614d2c771b7c9f4b47e24f514480c32def78
Cr-Commit-Position: refs/heads/master@{#404259}
==========

[commit-bot: I haz the power, 2016-07-07 22:25:36]

Patchset 2 (id:??) landed as
https://crrev.com/9da7614d2c771b7c9f4b47e24f514480c32def78
Cr-Commit-Position: refs/heads/master@{#404259}