Issue 212483003: CSS Transforms: Implement transform-origin

Issue 212483003: CSS Transforms: Implement transform-origin (Closed)

Created:
6 years, 9 months ago by dstockwell

Modified:
6 years, 8 months ago

Reviewers:
eseidel

CC:
blink-reviews, ed+blinkwatch_opera.com, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), rwlbuis, rune+blink, dglazkov+blink, dstockwell, Timothy Loh, apavlov+blink_chromium.org, darktears, Steve Block, dino_apple.com, Eric Willigers, eseidel, esprehn, abarth-chromium, ojan, Julien - ping for review

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

CSS Transforms: Implement transform-origin Implements transform-origin as defined in CSS Transforms[1]. Behavior is similar to -webkit-transform-origin, however transform-origin is not a shorthand. New parsing and serialization (mostly matching Gecko) has been introduced. The animation system is modified to avoid running animations and transitions on both the prefixed and unprefixed variants at the same time. Internally, animations are mapped to the unprefixed variant. As animations operate directly on the RenderStyle storage the result of specifying an animation on either -webkit-transform-origin or transform-origin is the same. However, support for independent animation/transition of -webkit-transform-origin-* is removed. The X, Y and Z coordinates now always transition together. Note, this property and changes in behavior are guarded by the CSSTransformsUnprefixed runtime feature (enabled only for testing). [1] http://www.w3.org/TR/css3-transforms/ BUG=154772 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170537

Patch Set 1 #

Patch Set 2 : Rebase. #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+350 lines, -75 lines)			Patch
M	LayoutTests/animations/interpolation/transform-origin-interpolation.html	View		1 chunk	+9 lines, -9 lines	0 comments	Download
M	LayoutTests/animations/interpolation/transform-origin-interpolation-expected.txt	View		1 chunk	+12 lines, -12 lines	0 comments	Download
A +	LayoutTests/animations/interpolation/webkit-transform-origin-interpolation.html	View		1 chunk	+8 lines, -8 lines	0 comments	Download
A	LayoutTests/animations/interpolation/webkit-transform-origin-interpolation-expected.txt	View		1 chunk	+16 lines, -0 lines	0 comments	Download
A	LayoutTests/transforms/transform-origin-parsing.html	View		1 chunk	+53 lines, -0 lines	0 comments	Download
A +	LayoutTests/transitions/unprefixed-transform-origin.html	View		2 chunks	+9 lines, -4 lines	0 comments	Download
A	LayoutTests/transitions/unprefixed-transform-origin-expected.txt	View		1 chunk	+19 lines, -0 lines	0 comments	Download
A +	Source/core/animation/AnimatableLengthPoint3D.h	View		2 chunks	+18 lines, -15 lines	0 comments	Download
A +	Source/core/animation/AnimatableLengthPoint3D.cpp	View		2 chunks	+17 lines, -14 lines	0 comments	Download
M	Source/core/animation/AnimatableValue.h	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	Source/core/animation/css/CSSAnimatableValueFactory.cpp	View		2 chunks	+10 lines, -0 lines	0 comments	Download
M	Source/core/animation/css/CSSAnimations.cpp	View	1	3 chunks	+12 lines, -3 lines	0 comments	Download
M	Source/core/animation/css/CSSPropertyEquality.cpp	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/core/core.gypi	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/core/css/CSSComputedStyleDeclaration.cpp	View	1	4 chunks	+3 lines, -1 line	0 comments	Download
M	Source/core/css/CSSProperties.in	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/css/StylePropertySerializer.cpp	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/css/parser/CSSPropertyParser.h	View	1	2 chunks	+3 lines, -2 lines	0 comments	Download
M	Source/core/css/parser/CSSPropertyParser.cpp	View	1	6 chunks	+80 lines, -6 lines	0 comments	Download
M	Source/core/css/resolver/AnimatedStyleBuilder.cpp	View		2 chunks	+12 lines, -0 lines	0 comments	Download
M	Source/core/css/resolver/StyleBuilderCustom.cpp	View	1	3 chunks	+61 lines, -1 line	0 comments	Download

Messages

Total messages: 12 (0 generated)

Expand Messages | Collapse Messages

dstockwell

Depends on: https://codereview.chromium.org/212543003/

6 years, 9 months ago (2014-03-26 10:39:11 UTC) #1