Adding media browsing benchmark.

tools/perf/benchmarks/browse_media.py

+# Copyright 2016 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be

[petrcermak, 2016/07/07 15:04:45]

This file is pretty much the same as news.py in
https://codereview.chromium.org/2118293002/. Could you please avoid code
duplication by re-using the code across the two benchmarks (perhaps they could
even be defined in the same file given how similar they are)?

+# found in the LICENSE file.
+
+import re
+
+from core import perf_benchmark
+from telemetry.timeline import chrome_trace_config
+from telemetry.timeline import chrome_trace_category_filter
+from telemetry.web_perf import timeline_based_measurement
+import page_sets
+
+# See tr.v.Numeric.getSummarizedScalarNumericsWithNames()
+# https://github.com/catapult-project/catapult/blob/master/tracing/tracing/value /numeric.html#L323
+_IGNORED_MEMORY_STATS_RE = re.compile(r'_(std|count|min|sum|pct_\d{4}(_\d+)?)$')
+_MEMORY_STATS_RE = re.compile(r'renderer_processes')
+
+# Track only the high-level GC stats to reduce the data load on dashboard.
+_IGNORED_V8_STATS_RE = re.compile(
+    r'_(idle_deadline_overrun|percentage_idle|outside_idle)')
+_V8_GC_HIGH_LEVEL_STATS_RE = re.compile(
+    r'v8-gc-incremental-finalize_|'
+    r'v8-gc-incremental-step_|'
+    r'v8-gc-latency-mark-compactor_|'
+    r'v8-gc-memory-mark-compactor_|'
+    r'v8-gc-scavenger_|'
+    r'v8-gc-total_')
+
+
+class _BrowseMediaBenchmark(perf_benchmark.PerfBenchmark):
+  """ Base class for media browsing benchmarks.
+  This benchmark measures memory usage with periodic memory dumps and v8 times.
+  See page_sets.media_browsing_stories._BrowseMediaStory for workload
+  description.
+  """
+
+  def CreateTimelineBasedMeasurementOptions(self):
+    categories = [
+      # Disable all categories by default.
+      '-*',
+      # Memory categories.
+      'disabled-by-default-memory-infra',
+      # V8 categories.
+      'blink.console',
+      'disabled-by-default-v8.gc',
+      'renderer.scheduler',
+      'v8',
+      'webkit.console',
+    ]
+    options = timeline_based_measurement.Options(
+        chrome_trace_category_filter.ChromeTraceCategoryFilter(
+            ','.join(categories)))
+    options.config.enable_android_graphics_memtrack = True
+    # Trigger periodic light memory dumps every 1000 ms.
+    memory_dump_config = chrome_trace_config.MemoryDumpConfig()
+    memory_dump_config.AddTrigger('light', 1000)
+    options.config.chrome_trace_config.SetMemoryDumpConfig(memory_dump_config)
+    options.SetTimelineBasedMetric('v8AndMemoryMetrics')
+    return options
+
+  @classmethod
+  def Name(cls):
+    return 'browse_media_%s' % cls.page_set.PLATFORM
+
+  @classmethod
+  def ValueCanBeAddedPredicate(cls, value, is_first_result):
+    # TODO(crbug.com/610962): Remove this stopgap when the perf dashboard
+    # is able to cope with the data load generated by TBMv2 metrics.
+    if 'memory:chrome' in value.name:
+      return (_MEMORY_STATS_RE.search(value.name) and
+              not _IGNORED_MEMORY_STATS_RE.search(value.name))
+    return (_V8_GC_HIGH_LEVEL_STATS_RE.search(value.name) and
+            not _IGNORED_V8_STATS_RE.search(value.name))
+
+  @classmethod
+  def ShouldTearDownStateAfterEachStoryRun(cls):
+    return True
+
+class MobileBrowseMediaBenchmark(_BrowseMediaBenchmark):

[petrcermak, 2016/07/07 15:04:45]

nednguyen: I can see many benchmarks having to do this (define a mobile- and
desktop-specific subclass). Is there any way we could simplify things?

idea: if it were possible to figure out the current platform in CreateStorySet,
all of this would be unnecessary:

class BrowseMediaBenchmark(perf_benchmark.PerfBenchmack):

  ...

  def CreateStorySet(self, finder_options):
    if finder_options.somehow.figure.out.the.platform.GetDeviceTypeName() ==
'Desktop':
      return page_sets.DesktopBrowseMediaStorySet()
    else:
      return page_sets.MobileBrowseMediaStorySet()

  ...

WDYT?

+  page_set = page_sets.MobileBrowseMediaStorySet
+
+  @classmethod
+  def ShouldDisable(cls, possible_browser):
+    return possible_browser.platform.GetDeviceTypeName() == 'Desktop'
+
+class DesktopNewsBenchmark(_BrowseMediaBenchmark):
+  page_set = page_sets.DesktopBrowseMediaStorySet
+
+  @classmethod
+  def ShouldDisable(cls, possible_browser):
+    return possible_browser.platform.GetDeviceTypeName() != 'Desktop'