src/full-codegen/arm/full-codegen-arm.cc - Issue 2124813002: [debugger] omit exception events for rethrown exceptions in async.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/full-codegen/arm/full-codegen-arm.cc

Issue 2124813002: [debugger] omit exception events for rethrown exceptions in async. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: typo fix Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/full-codegen/arm/full-codegen-arm.cc

diff --git a/src/full-codegen/arm/full-codegen-arm.cc b/src/full-codegen/arm/full-codegen-arm.cc

index 1e5d514d6ec2de70fa7b96aad0d535597a620252..8f313d523a3640cf3860780ca04a5a6d314fad39 100644

--- a/src/full-codegen/arm/full-codegen-arm.cc

+++ b/src/full-codegen/arm/full-codegen-arm.cc

@@ -1833,7 +1833,8 @@ void FullCodeGenerator::VisitYield(Yield* expr) {

EmitUnwindAndReturn();

__ bind(&exception);

- __ CallRuntime(Runtime::kThrow);

+ __ CallRuntime(IsAsyncFunction(literal()->kind()) ? Runtime::kReThrow

+ : Runtime::kThrow);

__ bind(&suspend);

OperandStackDepthIncrement(1); // Not popped on this path.

« no previous file with comments | « no previous file | src/full-codegen/arm64/full-codegen-arm64.cc » ('j') | src/interpreter/bytecode-generator.cc » ('J')