src/full-codegen/x64/full-codegen-x64.cc - Issue 2124813002: [debugger] omit exception events for rethrown exceptions in async.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/full-codegen/x64/full-codegen-x64.cc

Issue 2124813002: [debugger] omit exception events for rethrown exceptions in async. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/full-codegen/x64/full-codegen-x64.cc

diff --git a/src/full-codegen/x64/full-codegen-x64.cc b/src/full-codegen/x64/full-codegen-x64.cc

index 0e5cf985b8d9286f4192c9d6c6db93fcbae0b2e7..a36aa2721e9e67a451c09a4a60e9ab5d610bef2d 100644

--- a/src/full-codegen/x64/full-codegen-x64.cc

+++ b/src/full-codegen/x64/full-codegen-x64.cc

@@ -1773,7 +1773,8 @@ void FullCodeGenerator::VisitYield(Yield* expr) {

EmitUnwindAndReturn();

__ bind(&exception);

- __ CallRuntime(Runtime::kThrow);

+ __ CallRuntime(IsAsyncFunction(literal()->kind()) ? Runtime::kReThrow

+ : Runtime::kThrow);

Dan Ehrenberg 2016/07/07 00:25:41 LGTM

__ bind(&suspend);

OperandStackDepthIncrement(1); // Not popped on this path.

« no previous file with comments | « no previous file | src/interpreter/bytecode-array-builder.h » ('j') | src/interpreter/bytecode-array-builder.cc » ('J')