[debugger] omit exception events for rethrown exceptions in async.

[debugger] omit exception events for rethrown exceptions in async.

R=bmeurer@chromium.org, littledan@chromium.org
BUG=v8:5167
Committed: https://crrev.com/dfcc5d4ee88a737c7e151083ef1ba18a31f99687
Cr-Commit-Position: refs/heads/master@{#37623}

[Dan Ehrenberg, 2016-07-07 00:25:41]

Looks like a good approach to part of it; I guess all of those are rethrows. I'm
in favor of committing the code once it's ported to all the other platforms (and
could do this tomorrow if Yang doesn't have time).

https://codereview.chromium.org/2124813002/diff/1/src/full-codegen/x64/full-c...
File src/full-codegen/x64/full-codegen-x64.cc (right):

https://codereview.chromium.org/2124813002/diff/1/src/full-codegen/x64/full-c...
src/full-codegen/x64/full-codegen-x64.cc:1777: : Runtime::kThrow);
LGTM

https://codereview.chromium.org/2124813002/diff/1/src/interpreter/bytecode-ar...
File src/interpreter/bytecode-array-builder.cc (right):

https://codereview.chromium.org/2124813002/diff/1/src/interpreter/bytecode-ar...
src/interpreter/bytecode-array-builder.cc:635:
latest_source_info_.MakeStatementPosition(position);
What does this change have to do with the other part?

[Yang, 2016-07-07 04:00:47]

I'll port this today.

https://codereview.chromium.org/2124813002/diff/1/src/interpreter/bytecode-ar...
File src/interpreter/bytecode-array-builder.cc (right):

https://codereview.chromium.org/2124813002/diff/1/src/interpreter/bytecode-ar...
src/interpreter/bytecode-array-builder.cc:635:
latest_source_info_.MakeStatementPosition(position);
On 2016/07/07 00:25:41, Dan Ehrenberg wrote:
> What does this change have to do with the other part?

Since we now store the function literal anyways, we don't need to compute the
return position upfront anymore.

[Yang, 2016-07-07 09:58:27]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-07 09:58:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-07 10:04:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-07 10:04:11]

Dry run: Try jobs failed on following builders:
  v8_linux_mips64el_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)

[Yang, 2016-07-07 10:44:45]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-07 10:44:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-07 11:09:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-07 11:09:21]

Dry run: This issue passed the CQ dry run.

[Yang, 2016-07-07 12:47:27]

On 2016/07/07 11:09:21, commit-bot: I haz the power wrote:
> Dry run: This issue passed the CQ dry run.

Dan, please trigger CQ if you are fine with this.

[Yang, 2016-07-07 12:48:00]

On 2016/07/07 12:47:27, Yang wrote:
> On 2016/07/07 11:09:21, commit-bot: I haz the power wrote:
> > Dry run: This issue passed the CQ dry run.
> 
> Dan, please trigger CQ if you are fine with this.

ah... we still need Benedikt to sign off on this.

[Michael Starzinger, 2016-07-07 13:04:35]

mstarzinger@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[Michael Starzinger, 2016-07-07 13:04:36]

https://codereview.chromium.org/2124813002/diff/40001/src/interpreter/bytecod...
File src/interpreter/bytecode-generator.cc (right):

https://codereview.chromium.org/2124813002/diff/40001/src/interpreter/bytecod...
src/interpreter/bytecode-generator.cc:2264: if
(IsAsyncFunction(builder()->literal()->kind())) {
How would you feel about parameterizing the "Yield" AST node to indicate whether
a throw or a re-throw is requested? This way the AST node itself fully describes
semantics. This avoids having the non-local effect of semantics being different
depending in which AST the context the node appears. WDYT?

[Dan Ehrenberg, 2016-07-07 17:55:58]

The CQ bit was checked by littledan@chromium.org

[Dan Ehrenberg, 2016-07-07 17:55:58]

The patchset sent to the CQ was uploaded after l-g-t-m from
littledan@chromium.org
Link to the patchset: https://codereview.chromium.org/2124813002/#ps40001
(title: "typo fix")

[commit-bot: I haz the power, 2016-07-07 17:56:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dan Ehrenberg, 2016-07-07 17:56:11]

The CQ bit was unchecked by littledan@chromium.org

[Dan Ehrenberg, 2016-07-07 17:57:32]

https://codereview.chromium.org/2124813002/diff/40001/src/interpreter/bytecod...
File src/interpreter/bytecode-generator.cc (right):

https://codereview.chromium.org/2124813002/diff/40001/src/interpreter/bytecod...
src/interpreter/bytecode-generator.cc:2264: if
(IsAsyncFunction(builder()->literal()->kind())) {
On 2016/07/07 at 13:04:35, Michael Starzinger wrote:
> How would you feel about parameterizing the "Yield" AST node to indicate
whether a throw or a re-throw is requested? This way the AST node itself fully
describes semantics. This avoids having the non-local effect of semantics being
different depending in which AST the context the node appears. WDYT?

Looking forward to async generators, this is a really good idea, as those have
both 'yield' and 'await' Yield AST nodes. I believe the current code is correct,
FWIW.

[Yang, 2016-07-08 11:45:17]

Michi, do you want to take another look at this?

[Yang, 2016-07-08 11:51:00]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-08 11:51:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Michael Starzinger, 2016-07-08 13:18:50]

LGTM. Yup, exactly what I had in mind. Thanks! I didn't look at the parser.

[commit-bot: I haz the power, 2016-07-08 13:56:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-08 13:56:33]

Dry run: Try jobs failed on following builders:
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_TIMED_OUT,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)

[Dan Ehrenberg, 2016-07-08 16:06:00]

lgtm

[Benedikt Meurer, 2016-07-11 05:20:24]

LGTM.

[Yang, 2016-07-11 05:22:30]

The CQ bit was checked by yangguo@chromium.org

[commit-bot: I haz the power, 2016-07-11 05:22:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-11 05:48:00]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-07-11 05:50:13]

Description was changed from

==========
[debugger] omit exception events for rethrown exceptions in async.


R=bmeurer@chromium.org, littledan@chromium.org
BUG=v8:5167
==========

to

==========
[debugger] omit exception events for rethrown exceptions in async.

R=bmeurer@chromium.org, littledan@chromium.org
BUG=v8:5167

Committed: https://crrev.com/dfcc5d4ee88a737c7e151083ef1ba18a31f99687
Cr-Commit-Position: refs/heads/master@{#37623}
==========

[commit-bot: I haz the power, 2016-07-11 05:50:14]

Patchset 4 (id:??) landed as
https://crrev.com/dfcc5d4ee88a737c7e151083ef1ba18a31f99687
Cr-Commit-Position: refs/heads/master@{#37623}