Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Side by Side Diff: chrome/browser/resources/settings/site_settings/site_list.html

Issue 2124783002: Site Settings Desktop: Show menu right-aligned. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <link rel="import" href="chrome://resources/cr_elements/icons.html"> 1 <link rel="import" href="chrome://resources/cr_elements/icons.html">
2 <link rel="import" href="chrome://resources/html/polymer.html"> 2 <link rel="import" href="chrome://resources/html/polymer.html">
3 <link rel="import" href="chrome://resources/html/web_ui_listener_behavior.html"> 3 <link rel="import" href="chrome://resources/html/web_ui_listener_behavior.html">
4 <link rel="import" href="chrome://resources/polymer/v1_0/iron-icon/iron-icon.htm l"> 4 <link rel="import" href="chrome://resources/polymer/v1_0/iron-icon/iron-icon.htm l">
5 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-butt on.html"> 5 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-butt on.html">
6 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html"> 6 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html">
7 <link rel="import" href="chrome://resources/polymer/v1_0/paper-menu/paper-menu.h tml"> 7 <link rel="import" href="chrome://resources/polymer/v1_0/paper-menu/paper-menu.h tml">
8 <link rel="import" href="chrome://resources/polymer/v1_0/paper-menu/paper-submen u.html"> 8 <link rel="import" href="chrome://resources/polymer/v1_0/paper-menu/paper-submen u.html">
9 <link rel="import" href="chrome://resources/polymer/v1_0/paper-menu-button/paper -menu-button.html"> 9 <link rel="import" href="chrome://resources/polymer/v1_0/paper-menu-button/paper -menu-button.html">
10 <link rel="import" href="/i18n_setup.html"> 10 <link rel="import" href="/i18n_setup.html">
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
44 44
45 <div class="list-frame menu-content vertical-list" id="listContainer"> 45 <div class="list-frame menu-content vertical-list" id="listContainer">
46 <template is="dom-repeat" items="[[sites]]"> 46 <template is="dom-repeat" items="[[sites]]">
47 <div class="list-item underscore"> 47 <div class="list-item underscore">
48 <div class="favicon-image" style$="[[computeSiteIcon(item)]]" 48 <div class="favicon-image" style$="[[computeSiteIcon(item)]]"
49 on-tap="onOriginTap_" actionable></div> 49 on-tap="onOriginTap_" actionable></div>
50 <div class="middle" on-tap="onOriginTap_" actionable> 50 <div class="middle" on-tap="onOriginTap_" actionable>
51 <div>[[item.originForDisplay]]</div> 51 <div>[[item.originForDisplay]]</div>
52 <div class="secondary">[[item.embeddingOriginForDisplay]]</div> 52 <div class="secondary">[[item.embeddingOriginForDisplay]]</div>
53 </div> 53 </div>
54 <paper-menu-button hidden$="[[allSites]]"> 54 <paper-menu-button hidden$="[[allSites]]" horizontal-align="right">
Dan Beam 2016/07/06 15:26:33 what about in RTL?
Finnur 2016/08/19 16:13:30 OK, circling back to this CL that I was working on
tommycli 2016/08/22 23:33:00 Fixing LTR while leaving RTL no worse off is fine
55 <paper-icon-button icon="cr:more-vert" 55 <paper-icon-button icon="cr:more-vert"
56 class="dropdown-trigger"> 56 class="dropdown-trigger">
57 </paper-icon-button> 57 </paper-icon-button>
58 <paper-menu id="actionMenu" class="dropdown-content" 58 <paper-menu id="actionMenu" class="dropdown-content"
59 on-iron-activate="onActionMenuIronActivate_" 59 on-iron-activate="onActionMenuIronActivate_"
60 attr-for-selected="menu-value"> 60 attr-for-selected="menu-value">
61 <paper-item 61 <paper-item
62 hidden="[[!showAllowAction_]]" 62 hidden="[[!showAllowAction_]]"
63 menu-value$="[[PermissionValues.ALLOW]]"> 63 menu-value$="[[PermissionValues.ALLOW]]">
64 $i18n{siteSettingsActionAllow} 64 $i18n{siteSettingsActionAllow}
(...skipping 20 matching lines...) Expand all
85 <div class="button-container"> 85 <div class="button-container">
86 <paper-button on-tap="onAddSiteTap_" class="primary-button no-upper"> 86 <paper-button on-tap="onAddSiteTap_" class="primary-button no-upper">
87 $i18n{addSiteLink} 87 $i18n{addSiteLink}
88 </paper-button> 88 </paper-button>
89 </div> 89 </div>
90 </div> 90 </div>
91 </paper-submenu> 91 </paper-submenu>
92 </template> 92 </template>
93 <script src="site_list.js"></script> 93 <script src="site_list.js"></script>
94 </dom-module> 94 </dom-module>
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698