Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 2124773002: Support enclosingClass on deserialized local elements (Closed)

Created:
4 years, 5 months ago by Johnni Winther
Modified:
4 years, 5 months ago
Reviewers:
Harry Terkelsen
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Support enclosingClass on deserialized local elements R=het@google.com Committed: https://github.com/dart-lang/sdk/commit/4a7b1bb57ebb1461627370592b0fb50fb332c8f5

Patch Set 1 #

Patch Set 2 : Check local functions from implementation. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -2 lines) Patch
M pkg/compiler/lib/src/serialization/modelz.dart View 3 chunks +9 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/serialization/model_test_helper.dart View 1 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
4 years, 5 months ago (2016-07-05 12:08:25 UTC) #2
Harry Terkelsen
lgtm
4 years, 5 months ago (2016-07-06 16:17:39 UTC) #3
Johnni Winther
4 years, 5 months ago (2016-07-08 08:47:39 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
4a7b1bb57ebb1461627370592b0fb50fb332c8f5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698