Implements migration of a QUIC connection to a different destination address if specified by the se…

net/quic/quic_stream_factory.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_QUIC_QUIC_STREAM_FACTORY_H_
 #define NET_QUIC_QUIC_STREAM_FACTORY_H_
 
 #include <stddef.h>
 #include <stdint.h>
 
@@ skipping 278 matching lines @@
                                    const BoundNetLog& bound_net_log);
 
   // Method that initiates migration of |session| if |session| is
   // active and if there is an alternate network than the one to which
   // |session| is currently bound. If not null, |packet| is sent on
   // the new network, else a PING frame is sent.
   void MaybeMigrateSingleSession(QuicChromiumClientSession* session,
                                  MigrationCause migration_cause,
                                  scoped_refptr<StringIOBuffer> packet);
 
-  // Method that migrates |session| over to using |new_network|. If
-  // not null, |packet| is sent on the new network, else a PING frame
-  // is sent. Returns ERR_QUIC_PROTOCOL_ERROR if migration fails.
-  void MigrateSessionToNetwork(QuicChromiumClientSession* session,
-                               NetworkChangeNotifier::NetworkHandle new_network,
-                               const BoundNetLog& bound_net_log,
-                               scoped_refptr<StringIOBuffer> packet);
+  // Method that migrates |session| over to using |peer_address| and
+  // |new_network|. If not null, |packet| is sent on the new network,
+  // else a PING frame is sent.
+  void MigrateSessionToNewSocket(QuicChromiumClientSession* session,
+                                 IPEndPoint peer_address,
+                                 NetworkChangeNotifier::NetworkHandle network,

[Ryan Hamilton, 2016/07/06 19:29:37]

Can you document what happens when |network| is kInvalid?

Alternatively, consider making this method private and have two wrappers:
  MigrateSessionToNewNetwork
  MigrateSessionToNewPeerAddress

*shrug*

[Jana, 2016/07/12 22:34:10]

Good suggestion. Done.

+                                 const BoundNetLog& bound_net_log,
+                                 scoped_refptr<StringIOBuffer> packet);
 
   // NetworkChangeNotifier::IPAddressObserver methods:
 
   // Until the servers support roaming, close all connections when the local
   // IP address changes.
   void OnIPAddressChanged() override;
 
   // NetworkChangeNotifier::NetworkObserver methods:
   void OnNetworkConnected(
       NetworkChangeNotifier::NetworkHandle network) override;
@@ skipping 284 matching lines @@
   const scoped_refptr<SSLConfigService> ssl_config_service_;
 
   base::WeakPtrFactory<QuicStreamFactory> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(QuicStreamFactory);
 };
 
 }  // namespace net
 
 #endif  // NET_QUIC_QUIC_STREAM_FACTORY_H_