Reland of "Move UndoStack from Page to Editor"

third_party/WebKit/Source/core/editing/Editor.cpp

Index: third_party/WebKit/Source/core/editing/Editor.cpp
diff --git a/third_party/WebKit/Source/core/editing/Editor.cpp b/third_party/WebKit/Source/core/editing/Editor.cpp
index 07e3fc167a377e360d0d2e73b9571f722364a9ae..65bc530d200595f2c92a7c4362a51950cef46a0e 100644
--- a/third_party/WebKit/Source/core/editing/Editor.cpp
+++ b/third_party/WebKit/Source/core/editing/Editor.cpp
@@ -206,13 +206,6 @@ EditorClient& Editor::client() const
     return emptyEditorClient();
 }
 
-UndoStack* Editor::undoStack() const
-{
-    if (Page* page = frame().page())
-        return &page->undoStack();
-    return 0;
-}
-
 bool Editor::handleTextEvent(TextEvent* event)
 {
     // Default event handling for Drag and Drop will be handled by DragController
@@ -776,8 +769,7 @@ void Editor::appliedEditing(CompositeEditCommand* cmd)
         // Only register a new undo command if the command passed in is
         // different from the last command
         m_lastEditCommand = cmd;
-        if (UndoStack* undoStack = this->undoStack())
-            undoStack->registerUndoStep(m_lastEditCommand->ensureComposition());
+        m_undoStack->registerUndoStep(m_lastEditCommand->ensureComposition());
     }
 
     respondToChangedContents(newSelection);
@@ -797,8 +789,7 @@ void Editor::unappliedEditing(EditCommandComposition* cmd)
         changeSelectionAfterCommand(newSelection, FrameSelection::CloseTyping | FrameSelection::ClearTypingStyle);
 
     m_lastEditCommand = nullptr;
-    if (UndoStack* undoStack = this->undoStack())
-        undoStack->registerRedoStep(cmd);
+    m_undoStack->registerRedoStep(cmd);
     respondToChangedContents(newSelection);
 }
 
@@ -820,8 +811,7 @@ void Editor::reappliedEditing(EditCommandComposition* cmd)
         changeSelectionAfterCommand(newSelection, FrameSelection::CloseTyping | FrameSelection::ClearTypingStyle);
 
     m_lastEditCommand = nullptr;
-    if (UndoStack* undoStack = this->undoStack())
-        undoStack->registerUndoStep(cmd);
+    m_undoStack->registerUndoStep(cmd);
     respondToChangedContents(newSelection);
 }
 
@@ -832,6 +822,7 @@ Editor* Editor::create(LocalFrame& frame)
 
 Editor::Editor(LocalFrame& frame)
     : m_frame(&frame)
+    , m_undoStack(UndoStack::create())
     , m_preventRevealSelection(0)
     , m_shouldStartNewKillRingSequence(false)
     // This is off by default, since most editors want this behavior (this matches IE but not FF).
@@ -1066,28 +1057,27 @@ void Editor::copyImage(const HitTestResult& result)
 
 bool Editor::canUndo()
 {
-    if (UndoStack* undoStack = this->undoStack())
-        return undoStack->canUndo();
-    return false;
+    return m_undoStack->canUndo();
 }
 
 void Editor::undo()
 {
-    if (UndoStack* undoStack = this->undoStack())
-        undoStack->undo();
+    m_undoStack->undo();
 }
 
 bool Editor::canRedo()
 {
-    if (UndoStack* undoStack = this->undoStack())
-        return undoStack->canRedo();
-    return false;
+    return m_undoStack->canRedo();
 }
 
 void Editor::redo()
 {
-    if (UndoStack* undoStack = this->undoStack())
-        undoStack->redo();
+    m_undoStack->redo();
+}
+
+void Editor::clearUndoStack()
+{
+    return m_undoStack->clear();

[yosin_UTC9, 2016/07/06 01:04:51]

How about doing |m_undoStack->clear()| to move |Editor::clear()|, which is
called by |FrameLoader::clear()|?

[Xiaocheng, 2016/07/06 04:18:32]

It seems a saner idea as now UndoStack is just an implementation details of
Editor.

Done.

 }
 
 void Editor::setBaseWritingDirection(WritingDirection direction)
@@ -1440,6 +1430,7 @@ DEFINE_TRACE(Editor)
 {
     visitor->trace(m_frame);
     visitor->trace(m_lastEditCommand);
+    visitor->trace(m_undoStack);
     visitor->trace(m_mark);
 }