chrome/browser/ui/website_settings/permission_bubble_request.cc - Issue 2124703002: Record metrics for permission prompt acceptance vs. user gesture.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/website_settings/permission_bubble_request.cc

Issue 2124703002: Record metrics for permission prompt acceptance vs. user gesture. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add histograms Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/permissions/permission_bubble_request_impl.cc ('K') | « chrome/browser/ui/website_settings/permission_bubble_request.h ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/website_settings/permission_bubble_request.cc

diff --git a/chrome/browser/ui/website_settings/permission_bubble_request.cc b/chrome/browser/ui/website_settings/permission_bubble_request.cc

index 62afb9f9b5b9e215d7119447b1f1963b706777ac..7180ab069d32313f1eddf841cd2b7ee67bd90ef2 100644

--- a/chrome/browser/ui/website_settings/permission_bubble_request.cc

+++ b/chrome/browser/ui/website_settings/permission_bubble_request.cc

@@ -13,3 +13,7 @@ gfx::VectorIconId PermissionBubbleRequest::GetVectorIconId() const {

PermissionBubbleType PermissionBubbleRequest::GetPermissionBubbleType() const {

return PermissionBubbleType::UNKNOWN;

}

+PermissionBubbleGestureType PermissionBubbleRequest::GetGestureType() const {

+ return PermissionBubbleGestureType::UNKNOWN;