chrome/browser/ui/website_settings/mock_permission_bubble_request.h - Issue 2124703002: Record metrics for permission prompt acceptance vs. user gesture.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/website_settings/mock_permission_bubble_request.h

Issue 2124703002: Record metrics for permission prompt acceptance vs. user gesture. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add histograms Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/permissions/permission_bubble_request_impl.cc ('K') | « chrome/browser/permissions/permission_uma_util.cc ('k') | chrome/browser/ui/website_settings/mock_permission_bubble_request.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/website_settings/mock_permission_bubble_request.h

diff --git a/chrome/browser/ui/website_settings/mock_permission_bubble_request.h b/chrome/browser/ui/website_settings/mock_permission_bubble_request.h

index 38f27b88a2740e585557d9823cd134b1bf56884c..4b748f0e24ed3927b493ae1042560b5dfa490e95 100644

--- a/chrome/browser/ui/website_settings/mock_permission_bubble_request.h

+++ b/chrome/browser/ui/website_settings/mock_permission_bubble_request.h

@@ -14,7 +14,8 @@ class MockPermissionBubbleRequest : public PermissionBubbleRequest {

MockPermissionBubbleRequest();

explicit MockPermissionBubbleRequest(const std::string& text);

MockPermissionBubbleRequest(const std::string& text,

- PermissionBubbleType bubble_type);

+ PermissionBubbleType bubble_type,

+ PermissionBubbleGestureType gesture_type);

MockPermissionBubbleRequest(const std::string& text, const GURL& url);

MockPermissionBubbleRequest(const std::string& text,

const std::string& accept_label,

@@ -31,6 +32,7 @@ class MockPermissionBubbleRequest : public PermissionBubbleRequest {

void Cancelled() override;

void RequestFinished() override;

PermissionBubbleType GetPermissionBubbleType() const override;

+ PermissionBubbleGestureType GetGestureType() const override;

bool granted();

bool cancelled();

@@ -41,11 +43,13 @@ class MockPermissionBubbleRequest : public PermissionBubbleRequest {

const std::string& accept_label,

const std::string& deny_label,

const GURL& url,

- PermissionBubbleType bubble_type);

+ PermissionBubbleType bubble_type,

+ PermissionBubbleGestureType gesture_type);

bool granted_;

bool cancelled_;

bool finished_;

PermissionBubbleType bubble_type_;

+ PermissionBubbleGestureType gesture_type_;

base::string16 text_;

base::string16 accept_label_;