third_party/WebKit/Source/core/workers/DedicatedWorkerThread.h - Issue 2124693002: Worker: Fix broken GC logic on Dedicated Worker while DOMTimer is set

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/workers/DedicatedWorkerThread.h

Issue 2124693002: Worker: Fix broken GC logic on Dedicated Worker while DOMTimer is set (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/workers/DedicatedWorkerTest.cpp ('k') | third_party/WebKit/Source/core/workers/DedicatedWorkerThread.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/workers/DedicatedWorkerThread.h

diff --git a/third_party/WebKit/Source/core/workers/DedicatedWorkerThread.h b/third_party/WebKit/Source/core/workers/DedicatedWorkerThread.h

index c023d7a74c6a0087424f46c6bcd131ebb3160b47..6e60e5e63891d2835f30bcf5e4ec0e5c1c4b164f 100644

--- a/third_party/WebKit/Source/core/workers/DedicatedWorkerThread.h

+++ b/third_party/WebKit/Source/core/workers/DedicatedWorkerThread.h

@@ -38,7 +38,7 @@ namespace blink {

class InProcessWorkerObjectProxy;

class WorkerThreadStartupData;

-class DedicatedWorkerThread final : public WorkerThread {

+class CORE_EXPORT DedicatedWorkerThread : public WorkerThread {

public:

static std::unique_ptr<DedicatedWorkerThread> create(PassRefPtr<WorkerLoaderProxy>, InProcessWorkerObjectProxy&, double timeOrigin);

~DedicatedWorkerThread() override;

@@ -48,11 +48,11 @@ public:

InProcessWorkerObjectProxy& workerObjectProxy() const { return m_workerObjectProxy; }

protected:

+ DedicatedWorkerThread(PassRefPtr<WorkerLoaderProxy>, InProcessWorkerObjectProxy&, double timeOrigin);

WorkerOrWorkletGlobalScope* createWorkerGlobalScope(std::unique_ptr<WorkerThreadStartupData>) override;

- void postInitialize() override;

private:

- DedicatedWorkerThread(PassRefPtr<WorkerLoaderProxy>, InProcessWorkerObjectProxy&, double timeOrigin);

+ friend class DedicatedWorkerThreadForTest;

std::unique_ptr<WorkerBackingThread> m_workerBackingThread;

InProcessWorkerObjectProxy& m_workerObjectProxy;