Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(776)

Unified Diff: third_party/WebKit/Source/core/workers/DedicatedWorkerThread.h

Issue 2124693002: Worker: Fix broken GC logic on Dedicated Worker while DOMTimer is set (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: annotate WorkerGlobalScope interface with 'ActiveScriptWrappable' and make tests stricter Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/workers/DedicatedWorkerThread.h
diff --git a/third_party/WebKit/Source/core/workers/DedicatedWorkerThread.h b/third_party/WebKit/Source/core/workers/DedicatedWorkerThread.h
index 84ecd4e63884be3ed1eadeb4cc44b4f3578b4dd7..53470b9b60b97f759f149ac9351f90c1c32b5268 100644
--- a/third_party/WebKit/Source/core/workers/DedicatedWorkerThread.h
+++ b/third_party/WebKit/Source/core/workers/DedicatedWorkerThread.h
@@ -38,7 +38,7 @@ namespace blink {
class InProcessWorkerObjectProxy;
class WorkerThreadStartupData;
-class DedicatedWorkerThread final : public WorkerThread {
+class CORE_EXPORT DedicatedWorkerThread : public WorkerThread {
public:
static std::unique_ptr<DedicatedWorkerThread> create(PassRefPtr<WorkerLoaderProxy>, InProcessWorkerObjectProxy&, double timeOrigin);
~DedicatedWorkerThread() override;
@@ -47,11 +47,11 @@ public:
InProcessWorkerObjectProxy& workerObjectProxy() const { return m_workerObjectProxy; }
protected:
+ DedicatedWorkerThread(PassRefPtr<WorkerLoaderProxy>, InProcessWorkerObjectProxy&, double timeOrigin);
WorkerOrWorkletGlobalScope* createWorkerGlobalScope(std::unique_ptr<WorkerThreadStartupData>) override;
- void postInitialize() override;
private:
- DedicatedWorkerThread(PassRefPtr<WorkerLoaderProxy>, InProcessWorkerObjectProxy&, double timeOrigin);
+ friend class DedicatedWorkerThreadForTest;
std::unique_ptr<WorkerBackingThread> m_workerBackingThread;
InProcessWorkerObjectProxy& m_workerObjectProxy;

Powered by Google App Engine
This is Rietveld 408576698