third_party/WebKit/Source/core/frame/DOMTimerCoordinator.cpp - Issue 2124693002: Worker: Fix broken GC logic on Dedicated Worker while DOMTimer is set

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/DOMTimerCoordinator.cpp

Issue 2124693002: Worker: Fix broken GC logic on Dedicated Worker while DOMTimer is set (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: annotate WorkerGlobalScope interface with 'ActiveScriptWrappable' and make tests stricter Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/frame/DOMTimerCoordinator.h ('k') | third_party/WebKit/Source/core/workers/DedicatedWorkerGlobalScope.h » ('j') | third_party/WebKit/Source/core/workers/DedicatedWorkerTest.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/frame/DOMTimerCoordinator.cpp

diff --git a/third_party/WebKit/Source/core/frame/DOMTimerCoordinator.cpp b/third_party/WebKit/Source/core/frame/DOMTimerCoordinator.cpp

index e9311351a96a3eeec2cfae6bedbe32d40487b759..01e4007345710e22d4792ddf826b75145e486144 100644

--- a/third_party/WebKit/Source/core/frame/DOMTimerCoordinator.cpp

+++ b/third_party/WebKit/Source/core/frame/DOMTimerCoordinator.cpp

@@ -44,6 +44,11 @@ DOMTimer* DOMTimerCoordinator::removeTimeoutByID(int timeoutID)

return removedTimer;

}

+bool DOMTimerCoordinator::hasInstalledTimeout() const

+ return !m_timers.isEmpty();

DEFINE_TRACE(DOMTimerCoordinator)

{

visitor->trace(m_timers);