third_party/WebKit/Source/modules/compositorworker/CompositorWorkerMessagingProxy.cpp - Issue 2124693002: Worker: Fix broken GC logic on Dedicated Worker while DOMTimer is set

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/compositorworker/CompositorWorkerMessagingProxy.cpp

Issue 2124693002: Worker: Fix broken GC logic on Dedicated Worker while DOMTimer is set (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/workers/InProcessWorkerObjectProxy.cpp ('K') | « third_party/WebKit/Source/core/workers/WorkerThread.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/compositorworker/CompositorWorkerMessagingProxy.cpp

diff --git a/third_party/WebKit/Source/modules/compositorworker/CompositorWorkerMessagingProxy.cpp b/third_party/WebKit/Source/modules/compositorworker/CompositorWorkerMessagingProxy.cpp

index c6c7e9113f456e1b696f0397fdbba01773bee280..2c4e9550e3a2b847848bd38d93c87ff332f2ed18 100644

--- a/third_party/WebKit/Source/modules/compositorworker/CompositorWorkerMessagingProxy.cpp

+++ b/third_party/WebKit/Source/modules/compositorworker/CompositorWorkerMessagingProxy.cpp

@@ -4,6 +4,7 @@

#include "modules/compositorworker/CompositorWorkerMessagingProxy.h"

+#include "core/workers/InProcessWorkerBase.h"

#include "core/workers/WorkerThreadStartupData.h"

#include "modules/compositorworker/CompositorWorkerThread.h"

#include <memory>

@@ -11,7 +12,7 @@

namespace blink {

CompositorWorkerMessagingProxy::CompositorWorkerMessagingProxy(InProcessWorkerBase* worker, WorkerClients* workerClients)

- : InProcessWorkerMessagingProxy(worker, workerClients)

+ : InProcessWorkerMessagingProxy(worker->getExecutionContext(), worker, workerClients)

haraken 2016/08/05 08:20:58 Maybe is it redundant to pass both |worker| and |w

nhiroki 2016/08/08 09:19:14 Reverted this change (see my reply to kinuko's com

{

}

« third_party/WebKit/Source/core/workers/InProcessWorkerObjectProxy.cpp ('K') | « third_party/WebKit/Source/core/workers/WorkerThread.cpp ('k') | no next file » | no next file with comments »