🎣 Make Android .build_configs aware of prebuilts and java sources

Make Android .build_configs aware of prebuilts and java sources

This information will be necessary for generating gradle projects for
Android Studio.

BUG=620034
Committed: https://crrev.com/2bb3a690dc221b8a5dac4c4d99055e69ffe712b8
Cr-Commit-Position: refs/heads/master@{#403822}

[agrieve, 2016-07-05 01:09:26]

The CQ bit was checked by agrieve@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-05 01:09:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-05 02:19:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-05 02:19:04]

Dry run: This issue passed the CQ dry run.

[agrieve, 2016-07-05 16:10:19]

Description was changed from

==========
Make Android .build_configs aware of prebuilts and java sources

This information will be necessary for generating gradle projects for
Android Studio.

BUG=620034
==========

to

==========
Make Android .build_configs aware of prebuilts and java sources

This information will be necessary for generating gradle projects for
Android Studio.

BUG=620034
==========

[agrieve, 2016-07-05 16:10:19]

agrieve@chromium.org changed reviewers:
+ wnwen@chromium.org

[agrieve, 2016-07-05 16:10:24]

On 2016/07/05 02:19:04, commit-bot: I haz the power wrote:
> Dry run: This issue passed the CQ dry run.

[Peter Wen, 2016-07-05 17:46:47]

lgtm

Whenever I think I understand gn more, I realize I don't understand it at all. 🚲

https://codereview.chromium.org/2124663002/diff/1/build/android/gyp/javac.py
File build/android/gyp/javac.py (right):

https://codereview.chromium.org/2124663002/diff/1/build/android/gyp/javac.py#...
build/android/gyp/javac.py:331: if arg.startswith('@'):
Mind adding some comments for this somewhere?

[agrieve, 2016-07-05 18:36:43]

https://codereview.chromium.org/2124663002/diff/1/build/android/gyp/javac.py
File build/android/gyp/javac.py (right):

https://codereview.chromium.org/2124663002/diff/1/build/android/gyp/javac.py#...
build/android/gyp/javac.py:331: if arg.startswith('@'):
On 2016/07/05 17:46:47, Peter Wen wrote:
> Mind adding some comments for this somewhere?

Done.

[agrieve, 2016-07-05 18:36:58]

The CQ bit was checked by agrieve@chromium.org

[agrieve, 2016-07-05 18:36:59]

The patchset sent to the CQ was uploaded after l-g-t-m from wnwen@chromium.org
Link to the patchset: https://codereview.chromium.org/2124663002/#ps20001
(title: "add commetn")

[commit-bot: I haz the power, 2016-07-05 18:37:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-05 20:14:52]

Description was changed from

==========
Make Android .build_configs aware of prebuilts and java sources

This information will be necessary for generating gradle projects for
Android Studio.

BUG=620034
==========

to

==========
Make Android .build_configs aware of prebuilts and java sources

This information will be necessary for generating gradle projects for
Android Studio.

BUG=620034
==========

[commit-bot: I haz the power, 2016-07-05 20:14:53]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-05 20:16:17]

Description was changed from

==========
Make Android .build_configs aware of prebuilts and java sources

This information will be necessary for generating gradle projects for
Android Studio.

BUG=620034
==========

to

==========
Make Android .build_configs aware of prebuilts and java sources

This information will be necessary for generating gradle projects for
Android Studio.

BUG=620034

Committed: https://crrev.com/2bb3a690dc221b8a5dac4c4d99055e69ffe712b8
Cr-Commit-Position: refs/heads/master@{#403822}
==========

[commit-bot: I haz the power, 2016-07-05 20:16:18]

Patchset 2 (id:??) landed as
https://crrev.com/2bb3a690dc221b8a5dac4c4d99055e69ffe712b8
Cr-Commit-Position: refs/heads/master@{#403822}

[agrieve, 2016-07-06 19:26:32]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2126003002/ by agrieve@chromium.org.

The reason for reverting is: Breaks ninja noticing when .java files change..