Add new gpu driver bug workaround DISABLE_TRANSPARENT_VISUALS

ui/views/widget/widget_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <algorithm>
 #include <memory>
 #include <set>
 
 #include "base/bind.h"
-#include "base/command_line.h"
+#include "base/environment.h"
 #include "base/macros.h"
 #include "base/message_loop/message_loop.h"
 #include "base/run_loop.h"
 #include "base/strings/utf_string_conversions.h"
 #include "build/build_config.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "ui/base/hit_test.h"
 #include "ui/compositor/layer_animation_observer.h"
 #include "ui/compositor/scoped_animation_duration_scale_mode.h"
 #include "ui/compositor/scoped_layer_animation_settings.h"
@@ skipping 3716 matching lines @@
 
 #if !defined(OS_CHROMEOS)
 
 namespace {
 
 void InitializeWidgetForOpacity(
     Widget& widget,
     Widget::InitParams init_params,
     const Widget::InitParams::WindowOpacity opacity) {
 #if defined(USE_X11)
-  // On Linux, transparent visuals is currently not activated by default.
-  base::CommandLine* command_line = base::CommandLine::ForCurrentProcess();
-  command_line->AppendSwitch(switches::kEnableTransparentVisuals);
+  // testing/xvfb.py runs xvfb and xcompmgr.
+  std::unique_ptr<base::Environment> env(base::Environment::Create());
+  bool has_compositing_manager = env->HasVar("_CHROMIUM_INSIDE_XVFB");

[Ken Russell (switch to Gerrit), 2016/07/06 22:32:17]

This is a hack. Is there no better way to determine whether to try transparent
visuals?

[Julien Isorce Samsung, 2016/07/07 10:29:23]

The idea here is to only do EXPECT_EQ(depth, 32); if the test is ran under
src/testing/xvfb.py because now this script also starts a compositing manager
named xcompmgr. And I have not found a better to check that the test is ran
within this script. In any other configuration the test should not assert there,
for example it will fails with nvidia proprietary drivers if the driver contains
that bug.

+  int depth = 0;
+  ui::ChooseVisualForWindow(!has_compositing_manager, NULL, &depth);
 
-  int depth = 0;
-  ui::ChooseVisualForWindow(NULL, &depth);
-  EXPECT_EQ(depth, 32);
+  if (has_compositing_manager)
+    EXPECT_EQ(depth, 32);
 #endif
 
   init_params.opacity = opacity;
   init_params.show_state = ui::SHOW_STATE_NORMAL;
   init_params.bounds = gfx::Rect(0, 0, 500, 500);
   init_params.ownership = Widget::InitParams::WIDGET_OWNS_NATIVE_WIDGET;
   init_params.native_widget =
       CreatePlatformDesktopNativeWidgetImpl(init_params, &widget, nullptr);
   widget.Init(init_params);
 
 #if defined(USE_X11)
-  EXPECT_TRUE(widget.IsTranslucentWindowOpacitySupported());
+  if (has_compositing_manager)
+    EXPECT_TRUE(widget.IsTranslucentWindowOpacitySupported());
 #endif
 }
 
 }  // namespace
 
 // Test opacity when compositing is enabled.
 TEST_F(WidgetTest, Transparency_DesktopWidgetInferOpacity) {
   Widget widget;
   InitializeWidgetForOpacity(widget,
                              CreateParams(Widget::InitParams::TYPE_WINDOW),
@@ skipping 25 matching lines @@
                              CreateParams(Widget::InitParams::TYPE_WINDOW),
                              Widget::InitParams::TRANSLUCENT_WINDOW);
   EXPECT_EQ(IsNativeWindowTransparent(widget.GetNativeWindow()),
             widget.ShouldWindowContentsBeTransparent());
 }
 
 #endif  // !defined(OS_CHROMEOS)
 
 }  // namespace test
 }  // namespace views