Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2124603002: Revert of Increase batching for AA fill rects. (Closed)

Created:
4 years, 5 months ago by dogben
Modified:
4 years, 5 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@rectgeoms3
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Increase batching for AA fill rects. (patchset #4 id:60001 of https://codereview.chromium.org/2116823002/ ) Reason for revert: I believe this is causing the Chromium DEPS roll to fail due to linux_blink_rel. Reverting for now to get the roll going again. Original issue's description: > Increase batching for AA fill rects. > > This allows batching of rects provided without a local matrix when local coords are required and when the view matrix changes. > > It also allows batching of rects with a local matrix with rects without a local matrix. > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2116823002 > > Committed: https://skia.googlesource.com/skia/+/e525ecaf63f225f1da6e9834f7a291c06ad44d23 TBR=robertphillips@google.com,bsalomon@google.com NOTREECHECKS=true # Not skipping CQ checks because original CL landed more than 1 days ago. Committed: https://skia.googlesource.com/skia/+/d87a6b235672327f2fdff1616b64141e5d2cd4c6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+186 lines, -108 lines) Patch
M src/gpu/batches/GrAAFillRectBatch.cpp View 9 chunks +186 lines, -108 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
dogben
Created Revert of Increase batching for AA fill rects.
4 years, 5 months ago (2016-07-04 17:41:40 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2124603002/1
4 years, 5 months ago (2016-07-04 17:42:09 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-07-04 17:57:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2124603002/1
4 years, 5 months ago (2016-07-04 18:23:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2124603002/1
4 years, 5 months ago (2016-07-04 18:29:09 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-04 18:30:07 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/d87a6b235672327f2fdff1616b64141e5d2cd4c6

Powered by Google App Engine
This is Rietveld 408576698