Issue 21246: Add unit test for comparison of smi constants, loops, and...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 21246: Add unit test for comparison of smi constants, loops, and... (Closed)

Created:
11 years, 10 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Kevin Millikin (Chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/experimental/toiger/

Visibility:
Public.

Description

Add unit test for comparison of smi constants, loops, and switch statement with constant tests. Committed: http://code.google.com/p/v8/source/detail?r=1250

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+123 lines, -0 lines)			Patch
	A	test/mjsunit/compare-constants.js	View	1	1 chunk	+123 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Chromium)

11 years, 10 months ago (2009-02-11 13:02:54 UTC) #2

LGTM.

http://codereview.chromium.org/21246/diff/1/2
File test/mjsunit/compare-constants.js (right):

http://codereview.chromium.org/21246/diff/1/2#newcode1
Line 1: // Copyright 2008 the V8 project authors. All rights reserved.
2009.

Expand Messages | Collapse Messages