chrome/android/javatests/src/org/chromium/chrome/browser/accessibility/FontSizePrefsTest.java - Issue 2124583003: Replace Shared Prefs commit with apply.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/accessibility/FontSizePrefsTest.java

Issue 2124583003: Replace Shared Prefs commit with apply. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and fix merge conflict. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/ChromeBackupIntegrationTest.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/TabPersistentStoreTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/accessibility/FontSizePrefsTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/accessibility/FontSizePrefsTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/accessibility/FontSizePrefsTest.java

index 34828023349724130ffd107a41bf0bfb2d56d80e..32a617324d5d125f3e3c23baa8bcd0d94a154bbf 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/accessibility/FontSizePrefsTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/accessibility/FontSizePrefsTest.java

@@ -145,8 +145,7 @@ public class FontSizePrefsTest extends NativeLibraryTestBase {

// Delete PREF_USER_FONT_SCALE_FACTOR. This simulates the condition just after upgrading to

// M51, when userFontScaleFactor was added.

SharedPreferences.Editor editor = ContextUtils.getAppSharedPreferences().edit();

- editor.remove(FontSizePrefs.PREF_USER_FONT_SCALE_FACTOR);

- editor.commit();

+ editor.remove(FontSizePrefs.PREF_USER_FONT_SCALE_FACTOR).apply();

// Intial userFontScaleFactor should be set to fontScaleFactor / systemFontScale.

assertEquals(1.5f, getUserFontScaleFactor(), EPSILON);